Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check table under the public schema #5407

Merged
merged 3 commits into from Aug 14, 2021
Merged

Check table under the public schema #5407

merged 3 commits into from Aug 14, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Aug 14, 2021

What

How

  • Check table under the public schema.
  • Add unit tests.

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Although your comment makes me think of the cases where a user has the same table name as the airbyte table in the public schema with a different initialised schema.. That's a real edge case so think we can wait to handle it.

@tuliren
Copy link
Contributor Author

tuliren commented Aug 14, 2021

the cases where a user has the same table name as the airbyte table in the public schema with a different initialised schema

Right, this is possible. But I don't want to deal with such case. User should not touch the initial schema. If they do so, they are asking for trouble themselves.

@tuliren tuliren merged commit 2a82325 into master Aug 14, 2021
@tuliren tuliren deleted the liren/patch-table-check branch August 14, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check table existence under the public schema
2 participants