Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Chargebee: expand endpoint support #5421

Merged
merged 8 commits into from Aug 17, 2021
Merged

🎉 Source Chargebee: expand endpoint support #5421

merged 8 commits into from Aug 17, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Aug 16, 2021 •
edited

What

Closes #5045

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@Zirochkaa Zirochkaa self-assigned this Aug 16, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 16, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 16, 2021 •
edited by github-actions bot

/test connector=source-chargebee

🕑 source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1134282502
✅ source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1134282502

@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 04:58 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 16, 2021 •
edited by github-actions bot

/test connector=source-chargebee

🕑 source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1134304775
✅ source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1134304775

@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 05:08 Inactive
avida
avida approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@avida avida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart of Attachment "semi incremental" stream but if it was approved by Eugene/Sheriff Im ok with this

@Zirochkaa
Copy link
Contributor Author

/test connector=source-chargebee

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 16, 2021 •
edited by github-actions bot

/test connector=source-chargebee

🕑 source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1134447044
✅ source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1134447044

@jrhizor jrhizor temporarily deployed to more-secrets August 16, 2021 06:17 Inactive
sherifnada
sherifnada approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to proceed after addressing comments

docs/integrations/sources/chargebee.md Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-chargebee/source_chargebee/streams.py Show resolved Hide resolved
airbyte-integrations/connectors/source-chargebee/source_chargebee/streams.py Show resolved Hide resolved
airbyte-integrations/connectors/source-chargebee/source_chargebee/streams.py Show resolved Hide resolved
airbyte-integrations/connectors/source-chargebee/source_chargebee/streams.py Show resolved Hide resolved
docs/integrations/sources/chargebee.md Outdated Show resolved Hide resolved
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 17, 2021 •
edited by github-actions bot

/test connector=source-chargebee

🕑 source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1137903416
✅ source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1137903416

@jrhizor jrhizor temporarily deployed to more-secrets August 17, 2021 04:05 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 17, 2021 •
edited by github-actions bot

/publish connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1138088192
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1138088192

@jrhizor jrhizor temporarily deployed to more-secrets August 17, 2021 05:34 Inactive
@Zirochkaa Zirochkaa merged commit 70167aa into master Aug 17, 2021
@Zirochkaa Zirochkaa deleted the oleh/5045-source-chargebee-expand-endpoint-support branch August 17, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@avida avida avida approved these changes

@htrueman htrueman Awaiting requested review from htrueman

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

@davinchia davinchia Awaiting requested review from davinchia

@tuliren tuliren Awaiting requested review from tuliren

Assignees

@Zirochkaa Zirochkaa

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Source Chargebee: Expand endpoint support
5 participants
@Zirochkaa @avida @sherifnada @jrhizor @igrankova