Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Mailchimp: correct output schema to handle date-time values #5481

Merged
merged 2 commits into from Aug 18, 2021

Conversation

marcosmarxm
Copy link
Member

@marcosmarxm marcosmarxm commented Aug 17, 2021

What

Edit some fields where normalization are failing to cast timestamp with timezone.
Open #5480 to investigate further.

How

Remove date-time type from some fields.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 17, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 17, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 18, 2021

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1141402456
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1141402456

@jrhizor jrhizor temporarily deployed to more-secrets August 18, 2021 01:04 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 18, 2021

/publish connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1141489425
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1141489425

@jrhizor jrhizor temporarily deployed to more-secrets August 18, 2021 01:48 Inactive
@github-actions github-actions bot added the CDK Connector Development Kit label Aug 18, 2021
@marcosmarxm marcosmarxm force-pushed the marcosmarxm/correct-mailchimp-schema branch from 3f3d155 to 6463a03 Compare August 18, 2021 13:54
@github-actions github-actions bot removed the CDK Connector Development Kit label Aug 18, 2021
@marcosmarxm marcosmarxm merged commit 8c1a5d5 into master Aug 18, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/correct-mailchimp-schema branch August 18, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants