Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvest normalization failure: fixing the schemas #5701

Merged
merged 9 commits into from
Aug 31, 2021
Merged

Harvest normalization failure: fixing the schemas #5701

merged 9 commits into from
Aug 31, 2021

Conversation

vovavovavovavova
Copy link
Contributor

@vovavovavovavova vovavovavovavova commented Aug 27, 2021 •
edited
Loading

What

Closes #5473

How

By fixing the schema types. In most cases these are float numbers, that should be instead of integer, but there are also other changes (like object or array detalization). Changes were made by manual comparing the schema_generator_output and existing schemas, to avoid losing nulls everywhere.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 27, 2021
@vovavovavovavova vovavovavovavova changed the title Valdemar/#5473 harvest normalization failure Harvest normalization failure: fixing the schemas Aug 27, 2021
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174147155
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174147155

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 12:06 Inactive
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174200851
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174200851

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 12:24 Inactive
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174282697
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174282697

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 12:52 Inactive
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174385844
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174385844

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 13:26 Inactive
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174593111
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174593111

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 14:33 Inactive
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174639736
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174639736

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 14:48 Inactive
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174863438
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1174863438

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 16:04 Inactive
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 30, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1181113354
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1181113354

@jrhizor jrhizor temporarily deployed to more-secrets August 30, 2021 06:21 Inactive
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 30, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1181166751
✅ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1181166751

@jrhizor jrhizor temporarily deployed to more-secrets August 30, 2021 06:44 Inactive
keu
keu reviewed Aug 30, 2021
View reviewed changes
airbyte-integrations/connectors/source-harvest/source_harvest/streams.py Outdated
@@ -455,3 +464,4 @@ class ProjectBudget(ReportsBase):
"""

report_path = "project_budget"
primary_key = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you think this is common for all ReportsBase streams?
lets just move it there

keu
keu requested changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 30, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1182184929
✅ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1182184929

@jrhizor jrhizor temporarily deployed to more-secrets August 30, 2021 12:45 Inactive
@vovavovavovavova vovavovavovavova merged commit 90e909f into master Aug 31, 2021
@vovavovavovavova vovavovavovavova deleted the valdemar/#5473_harvest_normalization_failure branch August 31, 2021 06:45
@vovavovavovavova vovavovavovavova mentioned this pull request Aug 31, 2021
Merged
36 tasks
@jrhizor jrhizor mentioned this pull request Sep 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keu keu keu approved these changes

@tuliren tuliren tuliren approved these changes

@gaart gaart Awaiting requested review from gaart

@vitaliizazmic vitaliizazmic Awaiting requested review from vitaliizazmic

@davinchia davinchia Awaiting requested review from davinchia

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Harvest: failed in normalization step
4 participants
@vovavovavovavova @keu @tuliren @jrhizor