introduce a github action for open source release #5732

subodh1810 · 2021-08-30T11:40:40Z

Issue : #5459
Action to create a PR : https://github.com/marketplace/actions/create-pull-request

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions
Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

# Conflicts: # .bumpversion.cfg

subodh1810 · 2021-08-30T12:09:10Z

TODO(Subodh) : Need to add CLOUDREPO_USER and CLOUDREPO_PASSWORD to the secrets

jrhizor

Looks good overall. Just minor comments.

jrhizor · 2021-08-30T13:21:40Z

.github/workflows/release-airbyte-os.yml

+        run: |
+          echo "Pull Request Number - ${{ steps.cpr.outputs.pull-request-number }}"
+          echo "Pull Request URL - ${{ steps.cpr.outputs.pull-request-url }}"
+      - name: Next Steps


Can we put these steps in the PR body instead of the Github Action? I don't think anyone will look at this usually.

jrhizor · 2021-08-30T13:23:47Z

tools/bin/release_version.sh

@@ -44,15 +36,3 @@ SUB_BUILD=PLATFORM ./gradlew publish
 VERSION=$NEW_VERSION GIT_REVISION=$GIT_REVISION docker-compose -f docker-compose.build.yaml build
 VERSION=$NEW_VERSION GIT_REVISION=$GIT_REVISION docker-compose -f docker-compose.build.yaml push
 echo "Completed building and publishing..."
-
-echo
-echo "Changelog:"


Not blocking but nice to have:

It'd be cool if the changelog could also be put in the PR. I imagine you'd have to compute the changelog, save it to an output variable and then read it in the PR creation step?

This is done directly in the pr_body.sh now.

jrhizor · 2021-08-30T13:24:13Z

.github/workflows/release-airbyte-os.yml

+      - name: Next Steps
+        run: |
+          echo "Steps After Merging PR"
+          echo "1. Switch to master"


Suggested change

echo "1. Switch to master"

echo "1. Pull most recent version of master"

subodh1810 · 2021-08-30T22:38:09Z

@jrhizor I addressed your comments, take a look at this PR https://github.com/airbytehq/github-workflow-test-repo-base/pull/30 , this is how the output PR would look from this new workflow. Let me know if you have any more feedback

davinchia

Looks good!

davinchia · 2021-08-31T01:12:05Z

.github/workflows/release-airbyte-os.yml

+      - name: PR Details
+        run: |
+          echo "Pull Request Number - ${{ steps.cpr.outputs.pull-request-number }}"
+          echo "Pull Request URL - ${{ steps.cpr.outputs.pull-request-url }}"


nit: newline

davinchia · 2021-08-31T01:12:07Z

tools/bin/pr_body.sh

+echo "Steps After Merging PR:"
+echo "1. Pull most recent version of master"
+echo "2. Run ./tools/bin/tag_version.sh"
+echo "3. Create a GitHub release with the changelog"


nit: newline

davinchia · 2021-08-31T01:13:57Z

.github/workflows/release-airbyte-os.yml

+        env:
+          PREV_VERSION: ${{ steps.old_version.outputs.OLD_VERSION }}
+        run: |
+          chmod +x tools/bin/pr_body.sh


we can chmod the pr_body.sh script and check that in so we don't have to do this in the workflow everytime.

davinchia · 2021-08-31T01:18:50Z

.bumpversion.cfg

@@ -1,6 +1,6 @@
 [bumpversion]
 current_version = 0.29.13-alpha
-commit = True
+commit = False


to make sure I understand, this is false because we are manually creating the commit later on in the workflow yes?

@davinchia yup..now we dont want bumpversion to commit changes. It would be taken care by the workflow

tuliren · 2021-09-01T16:56:32Z

Wow, this is fancy!

introduce a github action for open source release

fd462c3

subodh1810 requested review from jrhizor and davinchia August 30, 2021 11:40

subodh1810 self-assigned this Aug 30, 2021

subodh1810 added 2 commits August 30, 2021 17:12

Merge branch 'master' into open-source-release-github-actions

385c9bf

# Conflicts: # .bumpversion.cfg

add more-secrets environment

11081a2

jrhizor approved these changes Aug 30, 2021

View reviewed changes

PR body should contain the changelog

e642080

update script

9ce8ecb

davinchia approved these changes Aug 31, 2021

View reviewed changes

add new lines

f5cd038

subodh1810 merged commit 3260a48 into master Aug 31, 2021

subodh1810 deleted the open-source-release-github-actions branch August 31, 2021 18:41

subodh1810 mentioned this pull request Aug 31, 2021

update release readme file #5768

Merged

36 tasks

jrhizor mentioned this pull request Sep 3, 2021

Bump Airbyte version from 0.29.13-alpha to 0.29.14-alpha #5831

Merged

igrankova added connectors/sources-api connectors/source/github labels Jan 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

introduce a github action for open source release #5732

introduce a github action for open source release #5732

subodh1810 commented Aug 30, 2021

subodh1810 commented Aug 30, 2021

jrhizor left a comment

jrhizor Aug 30, 2021

jrhizor Aug 30, 2021

tuliren Sep 1, 2021

jrhizor Aug 30, 2021

subodh1810 commented Aug 30, 2021

davinchia left a comment

davinchia Aug 31, 2021

davinchia Aug 31, 2021

davinchia Aug 31, 2021

davinchia Aug 31, 2021

subodh1810 Aug 31, 2021

tuliren commented Sep 1, 2021

	echo "1. Switch to master"
	echo "1. Pull most recent version of master"

introduce a github action for open source release #5732

introduce a github action for open source release #5732

Conversation

subodh1810 commented Aug 30, 2021

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

subodh1810 commented Aug 30, 2021

jrhizor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

subodh1810 commented Aug 30, 2021

davinchia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tuliren commented Sep 1, 2021