-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Tool for generation catalog schema from OpenAPI definition file #5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avida
force-pushed
the
drezchykov/2652-catalog-json-schema-gen-tool
branch
from
August 30, 2021 13:37
658cd3e
to
c36fdd5
Compare
avida
changed the title
Drezchykov/2652 catalog json schema gen tool
Tool for generation catalog schema from OpenAPI definition file
Aug 30, 2021
avida
force-pushed
the
drezchykov/2652-catalog-json-schema-gen-tool
branch
from
August 30, 2021 14:30
c36fdd5
to
9479a19
Compare
yevhenii-ldv
approved these changes
Aug 30, 2021
htrueman
approved these changes
Aug 30, 2021
Zirochkaa
approved these changes
Aug 30, 2021
avida
force-pushed
the
drezchykov/2652-catalog-json-schema-gen-tool
branch
from
August 31, 2021 08:27
9479a19
to
cf14615
Compare
sherifnada
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have a couple of more requests to make this easily consumable by an Airbyte user.
- Can you add a note in the CDK docs advertising this tool maybe here. Something like a section which says that you can use this tool.
- Can you add some files to this directory
tools/openapi2jsonschema/examples
which are an example of generated files? e.g:
examples/
stripe-api/
stripe-openapi-spec.json
transactions.json
...
exit | ||
} | ||
|
||
docker images | grep "$IMG_TAG" > /dev/null || { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the lazy instantiation here
avida
force-pushed
the
drezchykov/2652-catalog-json-schema-gen-tool
branch
from
September 1, 2021 08:09
cf14615
to
c88ba23
Compare
github-actions
bot
added
the
area/documentation
Improvements or additions to documentation
label
Sep 1, 2021
avida
changed the title
Tool for generation catalog schema from OpenAPI definition file
🎉 Tool for generation catalog schema from OpenAPI definition file
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #2652
How
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes