-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Harvest: updated schemas to match with Harvest API #5747
Conversation
awesome @jadetr! I'll review later today! |
@marcosmarxm merged with the latest changes. last commit of this source connector was still failing on my side. Those changes fix it. |
@jadetr is it possible to you run tests locally? Now the CDK has some validations based on data returned by the API. If you need help reach me on Slack. Tests are failing: https://github.com/airbytehq/airbyte/runs/3527331020?check_suite_focus=true. |
Jade Tremblay seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @jadetr sorry took so long to review it.
@jadetr can you sign the CLA after I'll merge your code. |
@marcosmarxm CLa signed |
What
updated harvest source schema
How
Updated data type of some harvest schema file that were failing with BigQuery basic normalization
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here