Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Harvest: updated schemas to match with Harvest API #5747

Closed
wants to merge 6 commits into from
Closed

🐛 Source Harvest: updated schemas to match with Harvest API #5747

wants to merge 6 commits into from

Conversation

jadetr
Copy link
Contributor

@jadetr jadetr commented Aug 31, 2021

What

updated harvest source schema

How

Updated data type of some harvest schema file that were failing with BigQuery basic normalization

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 31, 2021
@marcosmarxm
Copy link
Member

awesome @jadetr! I'll review later today!

@marcosmarxm marcosmarxm self-assigned this Aug 31, 2021
@jadetr
Copy link
Contributor Author

jadetr commented Aug 31, 2021

@marcosmarxm merged with the latest changes. last commit of this source connector was still failing on my side. Those changes fix it.

@marcosmarxm
Copy link
Member

@jadetr is it possible to you run tests locally? Now the CDK has some validations based on data returned by the API. If you need help reach me on Slack. Tests are failing: https://github.com/airbytehq/airbyte/runs/3527331020?check_suite_focus=true.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jadetr
❌ Jade Tremblay


Jade Tremblay seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @jadetr sorry took so long to review it.

@marcosmarxm
Copy link
Member

@jadetr can you sign the CLA after I'll merge your code.

@marcosmarxm marcosmarxm mentioned this pull request Sep 28, 2021
38 tasks
@jadetr
Copy link
Contributor Author

jadetr commented Sep 28, 2021

@marcosmarxm CLa signed

@marcosmarxm
Copy link
Member

Hi @jadetr this code was merged into master with PR #6516 thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants