[protocol] add oauth params to connector specification #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
requested review from
ChristopheDuong and
cgardens
and removed request for
ChristopheDuong
ChristopheDuong
approved these changes
Sep 1, 2021
|
/publish-cdk dry-run=false
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Oauth params to connector specification. This will be used by other processes e.g: UI to hide these fields from being user input. In the future this block could be extended to contain a DSL description of a connector's Oauth process, like described here.
closes #5632
How
Adds the following structs
authSpecification: top-level object containing metadata depending on the type of auth a connector follows. Right now this is only oauth2.0. In the future it could be oauth2.1 or openauth.oauth2Specification: an object containing a 2d list which describes the parameters needed to kick off an oauth2 flow for a connectorRecommended reading order
There is but one file.
Pre-merge Checklist