mainly spec/config updates #5792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phlair
commented
Sep 1, 2021
| @@ -56,6 +56,7 @@ | |||
|
|
|||
| private final ParquetWriter<Record> parquetWriter; | |||
| private final AvroRecordFactory avroRecordFactory; | |||
| public final Schema parquetSchema; | |||
There was a problem hiding this comment.
@tuliren is there a better way to extract the schema from the parquet writer than this?
There was a problem hiding this comment.
I think this is the right way.
The schema is usually persisted at the beginning of the parquet file, but since we already have it here, we don't need to read it from the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tuliren I've tried to strip this back to mostly useful structural changes I added here.