🎉 New Source: TikTok Marketing #5887

antixar · 2021-09-07T15:30:17Z

What

This is the new connector.
Now there are developed the basic streams (Ads, Campaigns, Ad Groups and Advertisers) only. Others will be added after data padding

Pre-merge Checklist

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

…-marketing

antixar · 2021-09-10T12:27:21Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1221205142
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1221205142

airbyte-integrations/connectors/source-tiktok-marketing/integration_tests/catalog.json

airbyte-integrations/connectors/source-tiktok-marketing/integration_tests/sample_state.json

...tegrations/connectors/source-tiktok-marketing/source_tiktok_marketing/schemas/ad_groups.json

airbyte-integrations/connectors/source-tiktok-marketing/integration_tests/spec.json

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/source.py

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/streams.py

airbyte-integrations/connectors/source-tiktok-marketing/unit_tests/unit_test.py

docs/integrations/sources/tiktok-marketing.md

airbyte-integrations/connectors/source-tiktok-marketing/unit_tests/unit_test.py

antixar · 2021-09-23T14:39:33Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1266273573
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1266273573
🐛 https://gradle.com/s/hyo2jdrfkdg6g

antixar · 2021-09-23T14:54:07Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1266323375
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1266323375
🐛 https://gradle.com/s/klknnrdxs5mcw

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/streams.py

davinchia

Looks good! Almost there. Some small comments I want to figure out first before we merge in.

Can you also go through the checklist again? I think you've completed most of it.

…_tiktok_marketing/spec.py Co-authored-by: Davin Chia <davinchia@gmail.com>

antixar · 2021-10-13T15:57:31Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1338261961
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1338261961
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              197     93    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     111     11    90%
	 ------------------------------------------------------------------------
	 TOTAL                                                  853    415    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                  Stmts   Miss  Cover
	 ---------------------------------------------------------
	 source_tiktok_marketing/__init__.py       2      0   100%
	 source_tiktok_marketing/source.py        31      8    74%
	 source_tiktok_marketing/spec.py          45     15    67%
	 source_tiktok_marketing/streams.py      151      6    96%
	 ---------------------------------------------------------
	 TOTAL                                   229     29    87%

antixar · 2021-10-13T15:58:39Z

@davinchia , please check this PR again. I've updated its checklist

antixar · 2021-10-15T15:59:03Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1346612565
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1346612565
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                  Stmts   Miss  Cover
	 ---------------------------------------------------------
	 source_tiktok_marketing/__init__.py       2      0   100%
	 source_tiktok_marketing/source.py        31      8    74%
	 source_tiktok_marketing/spec.py          45     15    67%
	 source_tiktok_marketing/streams.py      151      6    96%
	 ---------------------------------------------------------
	 TOTAL                                   229     29    87%

antixar · 2021-10-15T16:10:23Z

/publish connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1346651579
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1346651579

was reviewed by Davin before

* create a new connector folder * add base classes * add schemas * add ads/ad_groups streams * update tests and docs * add a bootstrap file * update the base domain name for API * update the base domain name for API * update Dockerfile libs * remove unused comments * Update airbyte-integrations/connectors/source-tiktok-marketing/bootstrap.md Co-authored-by: George Claireaux <george@claireaux.co.uk> * Update airbyte-integrations/connectors/source-tiktok-marketing/bootstrap.md Co-authored-by: George Claireaux <george@claireaux.co.uk> * fix UI error with input parameters * fix problem with updated state * Update airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/spec.py Co-authored-by: Davin Chia <davinchia@gmail.com> * add an unit test * update README.md * bump version Co-authored-by: Maksym Pavlenok <maksym.pavlenok@globallogic.com> Co-authored-by: George Claireaux <george@claireaux.co.uk> Co-authored-by: Davin Chia <davinchia@gmail.com>

Maksym Pavlenok added 5 commits August 19, 2021 10:51

create a new connector folder

95eb7bb

add base classes

101a7b2

Merge remote-tracking branch 'origin' into antixar/4652-source-tiktok…

993ce15

…-marketing

add schemas

bbe278a

add ads/ad_groups streams

da49414

antixar self-assigned this Sep 7, 2021

github-actions bot added the area/connectors Connector related issues label Sep 7, 2021

antixar linked an issue Sep 7, 2021 that may be closed by this pull request

New Source: Tiktok Marketing API #4652

Closed

update tests and docs

4498ec9

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 8, 2021

antixar assigned midavadim and bazarnov and unassigned midavadim and bazarnov Sep 8, 2021

antixar requested review from bazarnov and midavadim September 8, 2021 14:06

Maksym Pavlenok added 2 commits September 9, 2021 11:58

Merge remote-tracking branch 'origin' into antixar/4652-source-tiktok…

5b6f653

…-marketing

add a bootstrap file

f6d04f1

jrhizor temporarily deployed to more-secrets September 10, 2021 12:30 Inactive

midavadim suggested changes Sep 14, 2021

View reviewed changes

Maksym Pavlenok added 2 commits September 23, 2021 16:15

merge with master

6662f53

update the base domain name for API

5f95863

antixar temporarily deployed to more-secrets September 23, 2021 14:35 Inactive

jrhizor temporarily deployed to more-secrets September 23, 2021 14:41 Inactive

update the base domain name for API

a323193

antixar temporarily deployed to more-secrets September 23, 2021 14:55 Inactive

jrhizor temporarily deployed to more-secrets September 23, 2021 14:56 Inactive

davinchia reviewed Oct 12, 2021

View reviewed changes

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/streams.py Outdated Show resolved Hide resolved

davinchia reviewed Oct 12, 2021

View reviewed changes

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/streams.py Show resolved Hide resolved

davinchia reviewed Oct 12, 2021

View reviewed changes

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/streams.py Outdated Show resolved Hide resolved

davinchia reviewed Oct 12, 2021

View reviewed changes

Update airbyte-integrations/connectors/source-tiktok-marketing/source…

e3788b3

…_tiktok_marketing/spec.py Co-authored-by: Davin Chia <davinchia@gmail.com>

antixar temporarily deployed to more-secrets October 12, 2021 16:24 Inactive

add an unit test

bd5cbf2

antixar temporarily deployed to more-secrets October 13, 2021 15:50 Inactive

update README.md

545ecc3

antixar temporarily deployed to more-secrets October 13, 2021 15:58 Inactive

antixar requested a review from davinchia October 13, 2021 15:58

jrhizor temporarily deployed to more-secrets October 13, 2021 15:59 Inactive

davinchia approved these changes Oct 14, 2021

View reviewed changes

Phlair removed their request for review October 14, 2021 18:24

merge with master

4c14271

antixar temporarily deployed to more-secrets October 15, 2021 15:29 Inactive

bump version

10514eb

antixar temporarily deployed to more-secrets October 15, 2021 15:53 Inactive

jrhizor temporarily deployed to more-secrets October 15, 2021 16:01 Inactive

jrhizor temporarily deployed to more-secrets October 15, 2021 16:12 Inactive

antixar merged commit 713fe61 into master Oct 15, 2021

antixar deleted the antixar/4652-source-tiktok-marketing branch October 15, 2021 16:24

jrhizor mentioned this pull request Oct 19, 2021

Bump Airbyte version from 0.30.20-alpha to 0.30.21-alpha #7145

Merged

avaidyanatha mentioned this pull request Nov 2, 2021

Source: TikTok for Business airbytehq/connector-contest#52

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: TikTok Marketing #5887

🎉 New Source: TikTok Marketing #5887

antixar commented Sep 7, 2021 •

edited

Loading

antixar commented Sep 10, 2021 •

edited by github-actions bot

Loading

antixar commented Sep 23, 2021 •

edited by github-actions bot

Loading

antixar commented Sep 23, 2021 •

edited by github-actions bot

Loading

davinchia left a comment

antixar commented Oct 13, 2021 •

edited by github-actions bot

Loading

antixar commented Oct 13, 2021

antixar commented Oct 15, 2021 •

edited by github-actions bot

Loading

antixar commented Oct 15, 2021 •

edited by github-actions bot

Loading

🎉 New Source: TikTok Marketing #5887

🎉 New Source: TikTok Marketing #5887

Conversation

antixar commented Sep 7, 2021 • edited Loading

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

antixar commented Sep 10, 2021 • edited by github-actions bot Loading

antixar commented Sep 23, 2021 • edited by github-actions bot Loading

antixar commented Sep 23, 2021 • edited by github-actions bot Loading

davinchia left a comment

Choose a reason for hiding this comment

antixar commented Oct 13, 2021 • edited by github-actions bot Loading

antixar commented Oct 13, 2021

antixar commented Oct 15, 2021 • edited by github-actions bot Loading

antixar commented Oct 15, 2021 • edited by github-actions bot Loading

antixar commented Sep 7, 2021 •

edited

Loading

antixar commented Sep 10, 2021 •

edited by github-actions bot

Loading

antixar commented Sep 23, 2021 •

edited by github-actions bot

Loading

antixar commented Sep 23, 2021 •

edited by github-actions bot

Loading

antixar commented Oct 13, 2021 •

edited by github-actions bot

Loading

antixar commented Oct 15, 2021 •

edited by github-actions bot

Loading

antixar commented Oct 15, 2021 •

edited by github-actions bot

Loading