Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Pipedrive source: add organizations stream #5943

Merged
merged 2 commits into from
Sep 10, 2021
Merged

🎉 Pipedrive source: add organizations stream #5943

merged 2 commits into from
Sep 10, 2021

Conversation

avida
Copy link
Contributor

@avida avida commented Sep 9, 2021

What

Resolves #5591

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 9, 2021
@avida avida force-pushed the drezchykov/pipedrive-organizations branch from 720d661 to 3728379 Compare September 9, 2021 11:00
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 9, 2021
@avida
Copy link
Contributor Author

avida commented Sep 9, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/1217015260
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/1217015260

@jrhizor jrhizor temporarily deployed to more-secrets September 9, 2021 11:03 Inactive
htrueman
htrueman reviewed Sep 9, 2021
View reviewed changes
airbyte-integrations/connectors/source-pipedrive/source_pipedrive/streams.py
record = record.get(self.data_field) or record
if self.primary_key in record and record[self.primary_key] is None:
# Convert "id: null" fields to "id: 0" since id is primary key and SAT checking if it not null.
record[self.primary_key] = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may just set primary_key=None and SAT will skip the stream from the pk validation.
Or is it may be some pks with integer values and some are None?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it may be some pks with integer values and some are None?

Yes this is the case, there is mixed null and integer values for activity_fields stream: https://pastebin.com/0KvSSzYp

Zirochkaa
Zirochkaa approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just small comments

airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pipedrive/source_pipedrive/streams.py Outdated Show resolved Hide resolved
@avida avida changed the title Pipedrive source: add organizatins stream 🎉 Pipedrive source: add organizatins stream Sep 9, 2021
@avida avida changed the title 🎉 Pipedrive source: add organizatins stream 🎉 Pipedrive source: add organizations stream Sep 9, 2021
@avida
Copy link
Contributor Author

avida commented Sep 10, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/1222175312
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/1222175312

@jrhizor jrhizor temporarily deployed to more-secrets September 10, 2021 17:35 Inactive
@avida avida merged commit 4fa05b7 into master Sep 10, 2021
@avida avida deleted the drezchykov/pipedrive-organizations branch September 10, 2021 17:46
@jrhizor jrhizor mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@htrueman htrueman htrueman approved these changes

@Zirochkaa Zirochkaa Zirochkaa approved these changes

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipedrive source: Export organisations
5 participants
@avida @sherifnada @htrueman @Zirochkaa @jrhizor