Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "android_last_seen_at" data type #6082

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Fix "android_last_seen_at" data type #6082

merged 4 commits into from
Sep 29, 2021

Conversation

ReptilianBrain
Copy link
Contributor

Intercom API send a timestamp for the "android_last_seen_at" field. Which cause issue later on when dbt tries to created the table.

2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - Database Error in model intercom__contacts (models/generated/airbyte_tables/dev_sandbox/intercom__contacts.sql)
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - Invalid digit, Value '-', Pos 4, Type: Long
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - DETAIL:
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - -----------------------------------------------
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - error: Invalid digit, Value '-', Pos 4, Type: Long
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - code: 1207
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - context: 2021-09-03T00:45:55Z
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - query: 131295371
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - location: :0
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - process: query3_51_131295371 [pid=0]
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - -----------------------------------------------
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - compiled SQL at ../build/run/airbyte_utils/models/generated/airbyte_tables/dev_sandbox/intercom__contacts.sql

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

Intercom API send a timestamp for the "android_last_seen_at" field.  Which cause issue later on when dbt tries to created the table.

2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - Database Error in model intercom__contacts (models/generated/airbyte_tables/dev_sandbox/intercom__contacts.sql)
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -   Invalid digit, Value '-', Pos 4, Type: Long 
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -   DETAIL:  
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -     -----------------------------------------------
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -     error:  Invalid digit, Value '-', Pos 4, Type: Long 
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -     code:      1207
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -     context:   2021-09-03T00:45:55Z
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -     query:     131295371
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -     location:  :0
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -     process:   query3_51_131295371 [pid=0]
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -     -----------------------------------------------
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 -   compiled SQL at ../build/run/airbyte_utils/models/generated/airbyte_tables/dev_sandbox/intercom__contacts.sql
@github-actions github-actions bot added the area/connectors Connector related issues label Sep 15, 2021
@marcosmarxm marcosmarxm self-assigned this Sep 15, 2021
@marcosmarxm
Copy link
Member

Thanks! I'll review today the change :)

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReptilianBrain Thanks for PR. We get the timestamp from Intercom API and in the schema, we write type integer which matches with API response. So, I didn't think we need change the schema. Could you test your issue on the last version of Intercom connector - #6087

@ReptilianBrain
Copy link
Contributor Author

Hello @lazebnyi

Thank you for your reply.

You are right the API documentation and response is giving the result as an integer.

My confusion comes from when I look at the content of _airbyte_raw_intercom__contacts (using the latest version of the connector)

The android_last_seen_at field data is shown as a timestamp.

here's a snippet of the data I see in the table

{"type":"contact","id":"5f57802cad3fce89b236c587","created_at":1599569964,"updated_at":1632402541,"signed_up_at":1632402541,"last_seen_at":1632402541,"last_contacted_at":1629986236,"android_last_seen_at":"2021-09-19T18:24:28Z"}}

Does this help investigating my issue ?

Thank you

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2021

CLA assistant check
All committers have signed the CLA.

@lazebnyi lazebnyi self-requested a review September 28, 2021 10:51
@marcosmarxm
Copy link
Member

@lazebnyi I tried to run Intercom with Integration Account and these fields are null so I can't validate it. Could you populate with some data to check it?

@ReptilianBrain can you assign the CLA? Besides that we only need to add data to this fields and runs tests! Looks good to me! :D thanks

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving based on user info! I'll wait @lazebnyi to merge this

@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/api Related to the api area/platform issues related to the platform area/frontend area/protocol area/worker Related to worker CDK Connector Development Kit kubernetes normalization and removed normalization area/platform issues related to the platform CDK Connector Development Kit area/protocol area/api Related to the api area/frontend kubernetes area/worker Related to worker labels Sep 29, 2021
@github-actions github-actions bot added area/api Related to the api area/platform issues related to the platform area/frontend area/protocol area/worker Related to worker CDK Connector Development Kit kubernetes normalization and removed area/platform issues related to the platform CDK Connector Development Kit kubernetes area/protocol normalization area/worker Related to worker area/api Related to the api area/frontend labels Sep 29, 2021
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped version

@lazebnyi
Copy link
Collaborator

@marcosmarxm need run tests and publish before merge

@lazebnyi
Copy link
Collaborator

lazebnyi commented Sep 29, 2021

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1286142758
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1286142758
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  778    432    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_intercom/__init__.py       2      0   100%
	 source_intercom/source.py       143     62    57%
	 -------------------------------------------------
	 TOTAL                           145     62    57%

@lazebnyi
Copy link
Collaborator

lazebnyi commented Sep 29, 2021

/publish connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1286169528
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1286169528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants