-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed test for gcs, csv, json-local, mongodb and meilisearch destination #6134
Conversation
/test connector=connectors/destination-meilisearch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, 2 small comments to make sure we know what is happening.
Other things:
- can we run all the tests for the modified connectors on the PR branch to confirm the modifications are right?
- can you follow the
Updating a Connector
checklist on the PR description? one thing we are missing here is the connector changelog update.
...rc/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java
Show resolved
Hide resolved
...ch/src/main/java/io/airbyte/integrations/destination/meilisearch/MeiliSearchDestination.java
Show resolved
Hide resolved
...va/io/airbyte/integrations/destination/meilisearch/MeiliSearchDestinationAcceptanceTest.java
Show resolved
Hide resolved
/test connector=connectors/destination-csv
|
/test connector=connectors/destination-json-local
|
/test connector=connectors/destination-gcs
|
/test connector=connectors/destination-mongodb
|
/test connector=connectors/destination-local-json
|
...rc/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java
Outdated
Show resolved
Hide resolved
@davinchia, I corrected all remarks and tested all destinations. Can I merge this pull request? |
@andriikorotkov go for it! |
/publish connector=connectors/destination-meilisearch
|
/publish connector=connectors/destination-meilisearch
|
What
Fixed test for gcs, csv, json-local, mongodb and meilisearch destination
How
Updated test for csv, json-local and gcs.
Added
emitted_at
field for meilisearch destination.Changed N copies from 1000 to 400 for
testSyncWithLargeRecordBatch
test - (this test hangs with a lot of entries for mongodb destination)Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes