Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Amplitude: Correct output schemas on cohorts, events, active_users, and average_session_lengths streams #6353

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

What

resolves #5974.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets September 21, 2021 15:04 Inactive
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 21, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Sep 21, 2021

/test connector=connectors/source-amplitude

🕑 connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/1258152619
✅ connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/1258152619
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                           Stmts   Miss  Cover
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------Coverage.py warning: No data was collected. (no-data-collected)
	 --------------------------------------------------
	 source_amplitude/__init__.py       2      2     0%
	 source_amplitude/api.py          122    122     0%
	 source_amplitude/source.py        24     24     0%
	 --------------------------------------------------
	 TOTAL                            148    148     0%

@jrhizor jrhizor temporarily deployed to more-secrets September 21, 2021 15:07 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yevhenii-ldv LGTM but just a comment on the namings:

  1. The PR title should describe what the "actual" fix here was. The problem here was the schema files were incorrect, so title should be something closer to :bug: source Amplitude: Correct output schemas on cohorts, events, active_users, and average_session_lengths streams
  2. Same thing for the changelog. The changelog is meant to be a document consumed by users, so saying "fix build" doesn't help them understand what actually changed :) it should be like checkin catalogs #1

| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| 0.1.2 | 2021-09-?? | [????](https://github.com/airbytehq/airbyte/pull/????) | Fix build (the issue is caused by the addition of a schema check by field `format`) |
| 0.1.1 | 2021-06-09 | [3973](https://github.com/airbytehq/airbyte/pull/3973) | Add AIRBYTE_ENTRYPOINT for kubernetes support |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for backfilling!

@yevhenii-ldv yevhenii-ldv changed the title 🐛 Source Amplitude: fix tests 🐛 Source Amplitude: Correct output schemas on cohorts, events, active_users, and average_session_lengths streams Sep 21, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Sep 21, 2021

/publish connector=connectors/source-amplitude

🕑 connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/1258322879
✅ connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/1258322879

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets September 21, 2021 15:53 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 21, 2021 15:54 Inactive
@yevhenii-ldv yevhenii-ldv merged commit 6ae1901 into master Sep 21, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/fix-amplitude-tests branch September 21, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source amplitude - fix build
6 participants