🎉 Source Google Sheets: Support connecting via oAuth webflow #6354
Conversation
github-actions
bot
added
the
area/documentation
|
|
gaart
changed the title
|
/test connector=connectors/source-google-sheets
|
gaart
changed the title
| @@ -4,18 +4,81 @@ | |||
| "$schema": "http://json-schema.org/draft-07/schema#", | |||
| "title": "Stripe Source Spec", | |||
| "type": "object", | |||
| "required": ["spreadsheet_id", "credentials_json"], | |||
| "additionalProperties": false, | |||
| "required": ["spreadsheet_id"], | |||
There was a problem hiding this comment.
Is "credentials" not required?
There was a problem hiding this comment.
the idea is to have a backward compatibility with the old-style config, and credentials are still required for auth through the UI
| "refresh_token" | ||
| ], | ||
| "properties": { | ||
| "auth_type": { |
There was a problem hiding this comment.
I think, auth_type shouldn't be part of specification. It should be recognized in code.
There was a problem hiding this comment.
@vitaliizazmic this practice is used in the others connectors, could you point to some code with a new approach?
| } | ||
| } | ||
| }, | ||
| "authSpecification": { |
| "client_secret": "invalid_secret", | ||
| "refresh_token": "invalid_token" | ||
| } | ||
| } |
| if credentials.get("auth_type") == "Service": | ||
| return service_account.Credentials.from_service_account_info(json.loads(credentials["service_account_info"]), scopes=scopes) | ||
| elif credentials.pop("auth_type") == "Client": | ||
| return client_account.Credentials.from_authorized_user_info(info=credentials) |
There was a problem hiding this comment.
I might be wrong, but what will happen here if the first comparison fail?
so the auth_type is already removed, would it always return None?
There was a problem hiding this comment.
ok, I read it as a two pops, but nevertheless can't we pop auth_type first and then do if/else logic?
|
/test connector=connectors/source-google-sheets
|
|
/test connector=connectors/source-google-sheets
|
|
/test connector=connectors/source-google-sheets
|
|
/publish connector=connectors/source-google-sheets
|
…hq#6354) * Add service account support * Upd oauth support * Upd auth creds selector
What
Add support for connecting via Ouath webflow
How
Update spec.json schema to support 2 types of authorization
Update google_sheets_source.py, get_credentials method which returns credentials for a specific authorization method
Update helpers.py, add logic for choosing authorization type
Pre-merge Checklist
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here