Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Asana: fix schemas and invalid_config.json #6402

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Sep 23, 2021

What

Closes #5975.

Pre-merge Checklist

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@Zirochkaa Zirochkaa self-assigned this Sep 23, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Sep 23, 2021
@Zirochkaa Zirochkaa changed the title Update schemas + update invalid config file 🐛 Source Asana: fix SAT tests Sep 23, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 23, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Sep 23, 2021

/test connector=source-asana

🕑 source-asana https://github.com/airbytehq/airbyte/actions/runs/1266286904
✅ source-asana https://github.com/airbytehq/airbyte/actions/runs/1266286904
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Coverage.py warning: No data was collected. (no-data-collected)
	 Name                       Stmts   Miss  Cover
	 ----------------------------------------------
	 source_asana/__init__.py       2      2     0%
	 source_asana/source.py        19     19     0%
	 source_asana/streams.py      118    118     0%
	 ----------------------------------------------
	 TOTAL                        139    139     0%

@Zirochkaa Zirochkaa temporarily deployed to more-secrets September 23, 2021 14:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 14:45 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you change the PR title to reflect what has actually changed about the connector i.e the schema?

@Zirochkaa Zirochkaa changed the title 🐛 Source Asana: fix SAT tests 🐛 Source Asana: fix schemas and invalid_config.json Sep 24, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Sep 24, 2021

/publish connector=connectors/source-asana

🕑 connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1270124880
✅ connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1270124880

@Zirochkaa Zirochkaa temporarily deployed to more-secrets September 24, 2021 14:05 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 24, 2021 14:06 Inactive
@Zirochkaa Zirochkaa merged commit fe3026d into master Sep 24, 2021
@Zirochkaa Zirochkaa deleted the oleh/5975-fix-asana-tests branch September 24, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/asana connectors/sources-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source asana - fix schema related failure
5 participants