🎉 Declare Oauth init parameters for 4 connector #6438

yevhenii-ldv · 2021-09-24T12:43:04Z

Annotate Oauth init parameters for connectors: Facebook Marketing/Pages, Instagram, Salesforce

What

closes #6166 (except for Google Connectors).

How

Describe the solution

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

…es, Instagram, Salesforce

yevhenii-ldv · 2021-09-24T12:43:24Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1269852514
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1269852514
🐛 https://gradle.com/s/vrheukb52ppo6

yevhenii-ldv · 2021-09-24T12:43:29Z

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1269852841
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1269852841
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                Stmts   Miss  Cover
	 -------------------------------------------------------
	 source_facebook_pages/__init__.py       2      0   100%
	 source_facebook_pages/metrics.py        4      0   100%
	 source_facebook_pages/source.py        20     11    45%
	 source_facebook_pages/streams.py       72     34    53%
	 -------------------------------------------------------
	 TOTAL                                  98     45    54%

yevhenii-ldv · 2021-09-24T12:43:44Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/1269853389
❌ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/1269853389
🐛 https://gradle.com/s/uuf3r6m62ckqu

yevhenii-ldv · 2021-09-24T12:43:51Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1269853778
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1269853778
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------Coverage.py warning: No data was collected. (no-data-collected)
	 --------------------------------------------------------
	 source_salesforce/__init__.py            2      2     0%
	 source_salesforce/api.py               114    114     0%
	 source_salesforce/exceptions.py          1      1     0%
	 source_salesforce/rate_limiting.py      22     22     0%
	 source_salesforce/source.py             51     51     0%
	 source_salesforce/streams.py           201    201     0%
	 --------------------------------------------------------
	 TOTAL                                  391    391     0%

avida

~~Please update all the oauthFlowInitParameters according to reference~~

airbyte/airbyte-protocol/models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml

Line 216 in 3378ba4

description:

You commit is ok, my bad

Zirochkaa

btw, why there are no changes for google connectors as mentioned here #5634?
Google Analytics is covered by #6414, but what about Google Ads and Google Search console?

yevhenii-ldv · 2021-09-24T14:29:48Z

@Zirochkaa Google Ads is here. As for the rest of Google connectors, @gaart took over this issue, so I did not touch them.

ChristopheDuong · 2021-09-27T12:21:13Z

Beware, we're having to slightly modify the oauth specs in this PR:
#6456

So connectors will have to be tweaked accordingly

ChristopheDuong · 2021-09-27T13:26:55Z

In the case of facebook connectors, see this comment too: #5989 (comment)

CLAassistant · 2021-09-27T17:23:58Z

All committers have signed the CLA.

…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release

sherifnada

@yevhenii-ldv could you update this to the new spec format?

sherifnada · 2021-09-29T08:11:08Z

airbyte-integrations/connectors/source-facebook-marketing/integration_tests/spec.json

+  "authSpecification": {
+    "auth_type": "oauth2.0",
+    "oauth2Specification": {
+      "oauthFlowInitParameters": [["access_token"]]


this should be updated as a output parameter using the new spec

@sherifnada Done, could u review this PR one more time, please?

…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release � Conflicts: � docs/integrations/sources/facebook-marketing.md

…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release

yevhenii-ldv · 2021-09-30T14:07:50Z

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1291377723
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1291377723
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     111     11    90%
	 ------------------------------------------------------------------------
	 TOTAL                                                  856    416    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                Stmts   Miss  Cover
	 -------------------------------------------------------
	 source_facebook_pages/__init__.py       2      0   100%
	 source_facebook_pages/metrics.py        4      0   100%
	 source_facebook_pages/source.py        20     11    45%
	 source_facebook_pages/streams.py       72     34    53%
	 -------------------------------------------------------
	 TOTAL                                  98     45    54%

yevhenii-ldv · 2021-09-30T14:07:58Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1291378065
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1291378065
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     111     11    90%
	 ------------------------------------------------------------------------
	 TOTAL                                                  856    416    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                    Stmts   Miss  Cover
	 -----------------------------------------------------------
	 source_facebook_marketing/__init__.py       2      0   100%
	 source_facebook_marketing/api.py           74     17    77%
	 source_facebook_marketing/common.py        35     11    69%
	 source_facebook_marketing/source.py        36     11    69%
	 source_facebook_marketing/streams.py      239     91    62%
	 -----------------------------------------------------------
	 TOTAL                                     386    130    66%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                    Stmts   Miss  Cover
	 -----------------------------------------------------------
	 source_facebook_marketing/__init__.py       2      0   100%
	 source_facebook_marketing/api.py           74     18    76%
	 source_facebook_marketing/common.py        35      1    97%
	 source_facebook_marketing/source.py        36     15    58%
	 source_facebook_marketing/streams.py      239     85    64%
	 -----------------------------------------------------------
	 TOTAL                                     386    119    69%

yevhenii-ldv · 2021-09-30T14:08:04Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/1291378580
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/1291378580
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     111     11    90%
	 ------------------------------------------------------------------------
	 TOTAL                                                  856    416    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                           Stmts   Miss  Cover
	 --------------------------------------------------
	 source_instagram/__init__.py       2      0   100%
	 source_instagram/api.py           59      5    92%
	 source_instagram/common.py        39     26    33%
	 source_instagram/source.py        38     11    71%
	 source_instagram/streams.py      207     90    57%
	 --------------------------------------------------
	 TOTAL                            345    132    62%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                           Stmts   Miss  Cover
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------Coverage.py warning: No data was collected. (no-data-collected)
	 --------------------------------------------------
	 source_instagram/__init__.py       2      2     0%
	 source_instagram/api.py           59     59     0%
	 source_instagram/common.py        39     39     0%
	 source_instagram/source.py        38     38     0%
	 source_instagram/streams.py      207    207     0%
	 --------------------------------------------------
	 TOTAL                            345    345     0%

yevhenii-ldv · 2021-09-30T14:27:38Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1291451484
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1291451484

yevhenii-ldv · 2021-09-30T14:39:24Z

/publish connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/1291496416
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/1291496416

yevhenii-ldv · 2021-09-30T14:40:20Z

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1291500169
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1291500169

yevhenii-ldv · 2021-09-30T14:40:37Z

/publish connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1291501123
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1291501123

yevhenii-ldv · 2021-09-30T15:02:17Z

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1291575024
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1291575024

yevhenii-ldv · 2021-09-30T15:14:51Z

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1291623978
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1291623978

* Annotate Oauth init parameters for connectors: Facebook Marketing/Pages, Instagram, Salesforce

Annotate Oauth init parameters for connectors: Facebook Marketing/Pag…

9773b58

…es, Instagram, Salesforce

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 24, 2021

This was linked to issues Sep 24, 2021

Source FB marketing: Declare oauth parameters #5633

Closed

Source Salesforce: declare oauth parameters in spec #5635

Closed

jrhizor temporarily deployed to more-secrets September 24, 2021 12:45 Inactive

avida suggested changes Sep 24, 2021

View reviewed changes

avida approved these changes Sep 24, 2021

View reviewed changes

Zirochkaa approved these changes Sep 24, 2021

View reviewed changes

yevhenii-ldv requested review from sherifnada, davinchia and Phlair September 27, 2021 06:36

Merge branch 'master' of https://github.com/airbytehq/airbyte into yk…

d1b43b4

…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release

sherifnada reviewed Sep 29, 2021

View reviewed changes

yevhenii-ldv added 2 commits September 29, 2021 15:52

Merge branch 'master' of https://github.com/airbytehq/airbyte into yk…

7e727ff

…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release � Conflicts: � docs/integrations/sources/facebook-marketing.md

update after review

416a0f8

yevhenii-ldv temporarily deployed to more-secrets September 29, 2021 13:10 Inactive

yevhenii-ldv requested a review from sherifnada September 29, 2021 13:10

sherifnada approved these changes Sep 29, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets September 30, 2021 08:48 Inactive

Merge branch 'master' of https://github.com/airbytehq/airbyte into yk…

6837f32

…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release

yevhenii-ldv temporarily deployed to more-secrets September 30, 2021 14:08 Inactive

jrhizor temporarily deployed to more-secrets September 30, 2021 14:09 Inactive

jrhizor temporarily deployed to more-secrets September 30, 2021 14:10 Inactive

bump versions

0b63729

yevhenii-ldv temporarily deployed to more-secrets September 30, 2021 14:28 Inactive

jrhizor temporarily deployed to more-secrets September 30, 2021 14:29 Inactive

jrhizor temporarily deployed to more-secrets September 30, 2021 14:42 Inactive

update salesforce connector

f81ff94

yevhenii-ldv temporarily deployed to more-secrets September 30, 2021 15:03 Inactive

jrhizor temporarily deployed to more-secrets September 30, 2021 15:04 Inactive

jrhizor temporarily deployed to more-secrets September 30, 2021 15:17 Inactive

yevhenii-ldv merged commit 65d62eb into master Sep 30, 2021

yevhenii-ldv deleted the ykurochkin/annotate-oauth-init-parameters-for-initial-cloud-release branch September 30, 2021 15:29

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022

🎉 Declare Oauth init parameters for 4 connector (airbytehq#6438)

79c0c0c

* Annotate Oauth init parameters for connectors: Facebook Marketing/Pages, Instagram, Salesforce

karinakuz added connectors/sources-api connectors/source/facebook-marketing labels Jan 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Declare Oauth init parameters for 4 connector #6438

🎉 Declare Oauth init parameters for 4 connector #6438

yevhenii-ldv commented Sep 24, 2021

yevhenii-ldv commented Sep 24, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 •

edited by github-actions bot

avida left a comment •

edited

Zirochkaa left a comment

yevhenii-ldv commented Sep 24, 2021

ChristopheDuong commented Sep 27, 2021

ChristopheDuong commented Sep 27, 2021

CLAassistant commented Sep 27, 2021 •

edited

sherifnada left a comment

sherifnada Sep 29, 2021

yevhenii-ldv Sep 29, 2021 •

edited

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

🎉 Declare Oauth init parameters for 4 connector #6438

🎉 Declare Oauth init parameters for 4 connector #6438

Conversation

yevhenii-ldv commented Sep 24, 2021

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

yevhenii-ldv commented Sep 24, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 • edited by github-actions bot

avida left a comment • edited

Choose a reason for hiding this comment

Zirochkaa left a comment

Choose a reason for hiding this comment

yevhenii-ldv commented Sep 24, 2021

ChristopheDuong commented Sep 27, 2021

ChristopheDuong commented Sep 27, 2021

CLAassistant commented Sep 27, 2021 • edited

sherifnada left a comment

Choose a reason for hiding this comment

sherifnada Sep 29, 2021

Choose a reason for hiding this comment

yevhenii-ldv Sep 29, 2021 • edited

Choose a reason for hiding this comment

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 • edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 24, 2021 •

edited by github-actions bot

avida left a comment •

edited

CLAassistant commented Sep 27, 2021 •

edited

yevhenii-ldv Sep 29, 2021 •

edited

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot

yevhenii-ldv commented Sep 30, 2021 •

edited by github-actions bot