Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Analytics Oauth Specs #6459

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

ChristopheDuong
Copy link
Contributor

@ChristopheDuong ChristopheDuong commented Sep 27, 2021

What

Describe what the change is solving
Follow-up to changes introduced by #6456

How

Update oauth specs for connector

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 27, 2021
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets September 27, 2021 12:01 Inactive
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets September 27, 2021 12:03 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 27, 2021 12:58 Inactive
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Sep 27, 2021

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1278358155
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1278358155
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       227    107    53%
	 ------------------------------------------------------------
	 TOTAL                                      229    107    53%

@jrhizor jrhizor temporarily deployed to more-secrets September 27, 2021 13:07 Inactive
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets September 27, 2021 15:42 Inactive
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2021

CLA assistant check
All committers have signed the CLA.

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Sep 27, 2021

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1279346604
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1279346604

@jrhizor jrhizor temporarily deployed to more-secrets September 27, 2021 17:37 Inactive
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets September 27, 2021 17:56 Inactive
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Sep 27, 2021

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1279435397
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1279435397

@jrhizor jrhizor temporarily deployed to more-secrets September 27, 2021 18:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants