Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Oracle Source: Add encryption options #6616

Merged
merged 12 commits into from
Oct 8, 2021

Conversation

VitaliiMaltsev
Copy link
Contributor

@VitaliiMaltsev VitaliiMaltsev commented Oct 1, 2021

What

We want to support TLS encryption when connecting to the Oracle source.

How

Add 3 options to Oracle source spec : Unecrypted, Oracle Native Network Encryption and TLS(Server certificate verification)

orcl_unenc
orcl_nne
m
orcl_tls

Recomended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 1, 2021
@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets October 1, 2021 16:12 Inactive
@VitaliiMaltsev VitaliiMaltsev changed the title Oracle Source: Add encryption options 🎉 Oracle Source: Add encryption options Oct 4, 2021
@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Oct 4, 2021

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1302881683
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1302881683
🐛 https://gradle.com/s/5ub22exlzg3aq

@jrhizor jrhizor temporarily deployed to more-secrets October 4, 2021 09:06 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 4, 2021
@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Oct 4, 2021

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1303015737
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1303015737
No Python unittests run

@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets October 4, 2021 09:41 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 4, 2021 09:43 Inactive
@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets October 4, 2021 09:45 Inactive
# Conflicts:
#	docs/integrations/sources/oracle.md
@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets October 4, 2021 10:13 Inactive
@alexandr-shegeda alexandr-shegeda linked an issue Oct 4, 2021 that may be closed by this pull request
5 tasks
@VitaliiMaltsev VitaliiMaltsev marked this pull request as ready for review October 5, 2021 14:25
Copy link
Contributor

@irynakruk irynakruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pr, just left few comments regarding code style and backward compatibility.

@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets October 5, 2021 16:42 Inactive
@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Oct 5, 2021

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1308508108
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1308508108
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets October 5, 2021 16:45 Inactive
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one!

@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets October 7, 2021 14:30 Inactive
@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Oct 8, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1319419767
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1319419767

@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets October 8, 2021 07:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 8, 2021 07:46 Inactive
vmaltsev added 2 commits October 8, 2021 10:49
@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Oct 8, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1319445132
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1319445132

@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets October 8, 2021 07:54 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 8, 2021 07:55 Inactive
@VitaliiMaltsev VitaliiMaltsev merged commit bb32c82 into master Oct 8, 2021
@VitaliiMaltsev VitaliiMaltsev deleted the vmaltsev/6011-oracle-source-tls branch October 8, 2021 08:38
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* OracleSource add encryption

* add tests

* add tests

* remove debug option from Dockerfile

* add docs and fix unit tests

* remove System.out.println

* fix checkstyle | remove 'encryption' from required fields

* update timeout to 30 seconds

* bump version to 0.3.6

* bump version to 0.3.7

Co-authored-by: vmaltsev <vitalii.maltsev@globallogic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Oracle source via TLS/SSL
6 participants