🎉 Asana source: Add oauth init flow parameters support #6832

avida · 2021-10-06T08:04:32Z

What

Resolves #6259

How

Describe the solution

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

avida · 2021-10-06T08:54:54Z

/test connector=connectors/source-asana

🕑 connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1311149119
❌ connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1311149119
🐛 Binary file (standard input) matches

avida · 2021-10-06T09:21:04Z

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1311244336
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1311244336

avida · 2021-10-06T09:30:22Z

/test connector=connectors/source-asana

🕑 connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1311274928
✅ connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1311274928
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                       Stmts   Miss  Cover
	 ----------------------------------------------
	 source_asana/__init__.py       2      0   100%
	 source_asana/oauth.py         10      0   100%
	 source_asana/source.py        27     14    48%
	 source_asana/streams.py      118     69    42%
	 ----------------------------------------------
	 TOTAL                        157     83    47%

yevhenii-ldv · 2021-10-06T12:24:26Z

airbyte-integrations/connectors/source-asana/source_asana/spec.json

@@ -4,15 +4,74 @@
    "$schema": "http://json-schema.org/draft-07/schema#",
    "title": "Asana Spec",
    "type": "object",
-    "required": ["access_token"],


Why we remove "required" param?

for backward compatability, see my another hotfix PR for github with explanatory comment #6833 (comment)

IMO, I like the option of canceling the config check during the read method more than removing the required field from the specification.

sherifnada · 2021-10-06T16:19:06Z

airbyte-integrations/connectors/source-asana/source_asana/spec.json

+              },
+              "client_id": {
+                "type": "string",
+                "title": "",


title and description should not be empty ;)

sherifnada · 2021-10-06T16:19:14Z

airbyte-integrations/connectors/source-asana/source_asana/spec.json

+                "type": "string",
+                "title": "",
+                "description": "",
+                "airbyte_secret": false


client ID is not a secret

sherifnada · 2021-10-06T16:19:38Z

airbyte-integrations/connectors/source-asana/source_asana/spec.json

+        "oneOf": [
+          {
+            "type": "object",
+            "title": "PAT Credentials",


why two titles?

Zirochkaa · 2021-10-06T17:30:52Z

airbyte-integrations/connectors/source-asana/source_asana/source.py

+    def _get_authenticator(config: dict) -> Union[TokenAuthenticator, AsanaOauth2Authenticator]:
+        if "access_token" in config:
+            # Before Oauth we had Person Access Token stored under "access_token"
+            # config filed, this code here is for backward compatability


Suggested change

# config filed, this code here is for backward compatability

# config field, this code here is for backward compatibility

Zirochkaa · 2021-10-06T17:33:33Z

airbyte-integrations/connectors/source-asana/unit_tests/test_oauth.py

+    a = AsanaOauth2Authenticator(
+        token_refresh_endpoint=URL,
+        client_secret="client_secret",
+        client_id="client_id",
+        refresh_token="refresh_token",
+    )
+    token = a.get_access_token()


Suggested change

a = AsanaOauth2Authenticator(

token_refresh_endpoint=URL,

client_secret="client_secret",

client_id="client_id",

refresh_token="refresh_token",

)

token = a.get_access_token()

authenticator = AsanaOauth2Authenticator(

token_refresh_endpoint=URL,

client_secret="client_secret",

client_id="client_id",

refresh_token="refresh_token",

)

token = authenticator.get_access_token()

avida · 2021-10-07T06:49:43Z

/publish connector=connectors/source-asana

🕑 connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1315053437
❌ connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1315053437

avida · 2021-10-07T06:55:33Z

/publish connector=connectors/source-asana

🕑 connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1315069447
✅ connectors/source-asana https://github.com/airbytehq/airbyte/actions/runs/1315069447

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 6, 2021

avida temporarily deployed to more-secrets October 6, 2021 08:05 Inactive

avida force-pushed the drezchykov/asana-oauth branch from 695a83c to 74f418b Compare October 6, 2021 08:54

avida temporarily deployed to more-secrets October 6, 2021 08:56 Inactive

jrhizor temporarily deployed to more-secrets October 6, 2021 08:57 Inactive

jrhizor temporarily deployed to more-secrets October 6, 2021 09:23 Inactive

Asana source: Add oauth init flow parameters support

8a86660

avida force-pushed the drezchykov/asana-oauth branch from 74f418b to 8a86660 Compare October 6, 2021 09:30

avida temporarily deployed to more-secrets October 6, 2021 09:31 Inactive

jrhizor temporarily deployed to more-secrets October 6, 2021 09:32 Inactive

avida requested review from Zirochkaa, htrueman and yevhenii-ldv October 6, 2021 09:43

yevhenii-ldv reviewed Oct 6, 2021

View reviewed changes

yevhenii-ldv approved these changes Oct 6, 2021

View reviewed changes

avida requested a review from sherifnada October 6, 2021 15:39

sherifnada approved these changes Oct 6, 2021

View reviewed changes

Zirochkaa approved these changes Oct 6, 2021

View reviewed changes

fix review comments

fa5b61b

avida temporarily deployed to more-secrets October 7, 2021 06:51 Inactive

jrhizor temporarily deployed to more-secrets October 7, 2021 06:52 Inactive

Merge remote-tracking branch 'origin/master' into drezchykov/asana-oauth

596c56e

avida temporarily deployed to more-secrets October 7, 2021 06:56 Inactive

jrhizor temporarily deployed to more-secrets October 7, 2021 06:57 Inactive

avida merged commit ae63696 into master Oct 7, 2021

avida deleted the drezchykov/asana-oauth branch October 7, 2021 07:15

avida changed the title ~~Asana source: Add oauth init flow parameters support~~ 🎉 Asana source: Add oauth init flow parameters support Oct 7, 2021

jrhizor mentioned this pull request Oct 7, 2021

Bump Airbyte version from 0.30.15-alpha to 0.30.16-alpha #6880

Merged

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022

Asana source: Add oauth init flow parameters support (airbytehq#6832)

3329cda

igrankova added connectors/sources-api connectors/source/asana labels Jan 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Asana source: Add oauth init flow parameters support #6832

🎉 Asana source: Add oauth init flow parameters support #6832

avida commented Oct 6, 2021

avida commented Oct 6, 2021 •

edited by github-actions bot

Loading

avida commented Oct 6, 2021 •

edited by github-actions bot

Loading

avida commented Oct 6, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv Oct 6, 2021

avida Oct 6, 2021 •

edited

Loading

yevhenii-ldv Oct 6, 2021

sherifnada Oct 6, 2021

sherifnada Oct 6, 2021

sherifnada Oct 6, 2021

Zirochkaa Oct 6, 2021

Zirochkaa Oct 6, 2021

avida commented Oct 7, 2021 •

edited by github-actions bot

Loading

avida commented Oct 7, 2021 •

edited by github-actions bot

Loading

	# config filed, this code here is for backward compatability
	# config field, this code here is for backward compatibility

🎉 Asana source: Add oauth init flow parameters support #6832

🎉 Asana source: Add oauth init flow parameters support #6832

Conversation

avida commented Oct 6, 2021

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

avida commented Oct 6, 2021 • edited by github-actions bot Loading

avida commented Oct 6, 2021 • edited by github-actions bot Loading

avida commented Oct 6, 2021 • edited by github-actions bot Loading

yevhenii-ldv Oct 6, 2021

Choose a reason for hiding this comment

avida Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

yevhenii-ldv Oct 6, 2021

Choose a reason for hiding this comment

sherifnada Oct 6, 2021

Choose a reason for hiding this comment

sherifnada Oct 6, 2021

Choose a reason for hiding this comment

sherifnada Oct 6, 2021

Choose a reason for hiding this comment

Zirochkaa Oct 6, 2021

Choose a reason for hiding this comment

Zirochkaa Oct 6, 2021

Choose a reason for hiding this comment

avida commented Oct 7, 2021 • edited by github-actions bot Loading

avida commented Oct 7, 2021 • edited by github-actions bot Loading

avida commented Oct 6, 2021 •

edited by github-actions bot

Loading

avida commented Oct 6, 2021 •

edited by github-actions bot

Loading

avida commented Oct 6, 2021 •

edited by github-actions bot

Loading

avida Oct 6, 2021 •

edited

Loading

avida commented Oct 7, 2021 •

edited by github-actions bot

Loading

avida commented Oct 7, 2021 •

edited by github-actions bot

Loading