Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Twilio: update schemas + turn on transformer for all streams #7034

Merged
merged 4 commits into from
Oct 18, 2021
Merged

🐛 Source Twilio: update schemas + turn on transformer for all streams #7034

merged 4 commits into from
Oct 18, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Oct 14, 2021 •
edited
Loading

What

Closes #6819.

Pre-merge Checklist

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@Zirochkaa Zirochkaa self-assigned this Oct 14, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 14, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 14, 2021 •
edited by github-actions bot
Loading

/test connector=source-twilio

🕑 source-twilio https://github.com/airbytehq/airbyte/actions/runs/1340695705
✅ source-twilio https://github.com/airbytehq/airbyte/actions/runs/1340695705
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	   self._warn("No data was collected.", slug="no-data-collected")
	 -----------------------------------------------
	 source_twilio/__init__.py       2      2     0%
	 source_twilio/auth.py           8      8     0%
	 source_twilio/source.py        22     22     0%
	 source_twilio/streams.py      204    204     0%
	 -----------------------------------------------
	 TOTAL                         236    236     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 14, 2021 07:02 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 14, 2021 07:03 Inactive
@avida
Copy link
Contributor

avida commented Oct 14, 2021

@Zirochkaa Dont forget to bump version in docker file/ airbyte-config dir

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 18, 2021 •
edited by github-actions bot
Loading

/test connector=source-twilio

🕑 source-twilio https://github.com/airbytehq/airbyte/actions/runs/1353006986
✅ source-twilio https://github.com/airbytehq/airbyte/actions/runs/1353006986
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_twilio/__init__.py       2      2     0%
	 source_twilio/auth.py           8      8     0%
	 source_twilio/source.py        22     22     0%
	 source_twilio/streams.py      212    212     0%
	 -----------------------------------------------
	 TOTAL                         244    244     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 18, 2021 03:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 03:39 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 18, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/1353031117
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/1353031117

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 18, 2021 03:51 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 03:52 Inactive
@Zirochkaa Zirochkaa merged commit f1ddfca into master Oct 18, 2021
@Zirochkaa Zirochkaa deleted the oleh/6819-fix-twilio-SAT branch October 18, 2021 04:05
@jrhizor jrhizor mentioned this pull request Oct 19, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@Zirochkaa @schlattk
🐛 Source Twilio: update schemas + turn on transformer for all streams (…
c333b09 
…airbytehq#7034)

* Update schemas + turn on transformer for all streams

* Update docs

* Transform RFC2822 datetime into ISO8601

* Bump connector's version + update `accounts` schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avida avida avida approved these changes

@sherifnada sherifnada sherifnada approved these changes

@htrueman htrueman Awaiting requested review from htrueman

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

@davinchia davinchia Awaiting requested review from davinchia

@Phlair Phlair Awaiting requested review from Phlair

Assignees

@Zirochkaa Zirochkaa

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix source twilio connector build
4 participants
@Zirochkaa @avida @sherifnada @jrhizor