Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃帀 New Source: Lemlist #7062

Merged
merged 6 commits into from
Oct 26, 2021
Merged

馃帀 New Source: Lemlist #7062

merged 6 commits into from
Oct 26, 2021

Conversation

iglikoxha
Copy link
Contributor

What

How

Add four streams for this source:

  • Team
  • Campaigns
  • Activities
  • Unsubscribes

Recommended reading order

  1. bootstrap.md
  2. spec.json
  3. Schemas under schemas/*.json
  4. source.py
  5. streams.py

Unit Test

Screenshot 2021-10-14 at 9 13 13 PM

Integration Test

Screenshot 2021-10-14 at 9 09 27 PM

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 14, 2021
@marcosmarxm marcosmarxm mentioned this pull request Oct 15, 2021
Closed
@marcosmarxm
Copy link
Member

Awesome @iglikoxha we're going to review this tomorrow later monday! thanks for your contribution!

@marcosmarxm marcosmarxm self-assigned this Oct 15, 2021
@marcosmarxm
Copy link
Member

Hi @iglikoxha can you run ./gradlew format to apply the default formating?

@harshithmullapudi harshithmullapudi mentioned this pull request Oct 20, 2021
Closed
@iglikoxha
Copy link
Contributor Author

Hi @iglikoxha can you run ./gradlew format to apply the default formating?

Done!

harshithmullapudi
harshithmullapudi suggested changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@harshithmullapudi harshithmullapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just small comments

airbyte-integrations/connectors/source-lemlist/sample_files/invalid_config.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-lemlist/sample_files/sample_config.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-lemlist/source_lemlist/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-lemlist/source_lemlist/streams.py Show resolved Hide resolved
marcosmarxm
marcosmarxm approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments! It's working 馃帀 馃殌 . Can you solve the small comments? After I'll merge this contribution!

@iglikoxha
Copy link
Contributor Author

Final comments! It's working 馃帀 馃殌 . Can you solve the small comments? After I'll merge this contribution!

All done!

@marcosmarxm marcosmarxm merged commit 19f2541 into airbytehq:master Oct 26, 2021
@jrhizor jrhizor mentioned this pull request Nov 1, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@iglikoxha @marcosmarxm @schlattk
馃帀 New Source: Lemlist (airbytehq#7062)
f0a6454 
* add source lemlist

* update change log

* apply default formating

* add comment, delete unnecessary files

* remove unnecessary things

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshithmullapudi harshithmullapudi harshithmullapudi requested changes

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees

@marcosmarxm marcosmarxm

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/lemlist
Projects
Community Contributed PRs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iglikoxha @CLAassistant @marcosmarxm @harshithmullapudi @octavia-squidington-iii @octavia-squidington-iv