Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating license-faq #7153

Merged
merged 8 commits into from
Oct 26, 2021
Merged

Creating license-faq #7153

merged 8 commits into from
Oct 26, 2021

Conversation

johnlafleur
Copy link
Contributor

We need to put the license faq a lot more forward in the docs.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 19, 2021
@johnlafleur johnlafleur temporarily deployed to more-secrets October 19, 2021 09:33 Inactive
@johnlafleur johnlafleur temporarily deployed to more-secrets October 19, 2021 09:38 Inactive
@johnlafleur johnlafleur temporarily deployed to more-secrets October 19, 2021 09:50 Inactive
michel-tricot
michel-tricot approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % the asset change.

DO you want to drop it from airbyte.io and redirect to the docs isntead?

docs/project-overview/licenses/license-faq.md Outdated
* **Airbyte Core** is licensed under the Elastic License 2.0 (ELv2).
* **Airbyte Cloud & Airbyte Enterprise** are both closed source and require a commercial license from Airbyte.

![Diagram of license structure](https://assets-global.website-files.com/605e01bc25f7e19a82e74788/6142675d8f67e640a5b3b407_Screen%20Shot%202021-09-16%20at%208.36.21%20AM.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to use an image in the repo and not an external image. @avaidyanatha can you help John for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, didn't manage to make it work. need your help on this @avaidyanatha :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnlafleur Just fixed it, pushed the change up to your branch :)

michel-tricot
michel-tricot reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should have a very simple mention of the license in the main readme and a link to the FAQ

@johnlafleur
Copy link
Contributor Author

johnlafleur commented Oct 20, 2021 •
edited

I wonder if we should have a very simple mention of the license in the main readme and a link to the FAQ

@michel-tricot do you mean in addition to what is suggested in this PR?

DO you want to drop it from airbyte.io and redirect to the docs isntead?

In that case, yes indeed.

@michel-tricot
Copy link
Contributor

yes something really simple. At the end of the Readme, we already have a license section. Maybe just add a quick note like: "For any question you have about ELv2, just visit xxx"

@johnlafleur
Copy link
Contributor Author

New suggestion on this.

@johnlafleur johnlafleur temporarily deployed to more-secrets October 20, 2021 06:25 Inactive
@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 21, 2021 01:54 Inactive
@johnlafleur johnlafleur temporarily deployed to more-secrets October 22, 2021 20:04 Inactive
@johnlafleur johnlafleur temporarily deployed to more-secrets October 26, 2021 11:23 Inactive
@johnlafleur johnlafleur merged commit 722f82d into master Oct 26, 2021
@johnlafleur johnlafleur deleted the docs-adding-license-faq branch October 26, 2021 11:25
@jrhizor jrhizor mentioned this pull request Nov 1, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@johnlafleur @avaidyanatha @schlattk
Creating license-faq (airbytehq#7153)
c7f9b94 
* Creating license-faq

* Updating links in Licenses and more details on examples

* Create examples.md

* Update SUMMARY.md

* Update README.md

* Fix license FAQ asset.

* Update license-faq.md

* Update license-faq.md

Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-tricot michel-tricot michel-tricot approved these changes

@avaidyanatha avaidyanatha avaidyanatha left review comments

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnlafleur @michel-tricot @avaidyanatha