New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Mailchimp: support oauth flow #7159

Merged

annalvova05 merged 38 commits into master from alvova/6273-add-oauth-implementation

Jan 17, 2022

Contributor

annalvova05 commented Oct 19, 2021 •

edited by keu

Loading

What

Add Mailchimp OAuth support.

Java oAuth tests are passed.

How

Change spec.json and source.py

Recommended reading order

spec.json
source.py
MailchimpOAuthFlow.java

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

This change is


          add mailchimp oauth support

c27c4d9

annalvova05 requested review from antixar and lazebnyi

October 19, 2021 11:39

annalvova05 self-assigned this

github-actions bot added area/connectors area/documentation labels

annalvova05 linked an issue

that may be closed by this pull request

Source Mailchimp: support oauth #6273

Closed

1 task


          add PR

1b7715f

annalvova05 temporarily deployed to more-secrets

October 19, 2021 11:42

Inactive


          fix creds

226b93e

annalvova05 temporarily deployed to more-secrets

October 19, 2021 11:55

Inactive

annalvova05 added 2 commits

October 19, 2021 18:47


          upd spec

38a5c2f


          format

304dc83

annalvova05 temporarily deployed to more-secrets

October 19, 2021 16:27

Inactive

Contributor Author

annalvova05 commented Oct 27, 2021 •

edited by github-actions bot

Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1389344915
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1389344915
🐛

jrhizor temporarily deployed to more-secrets

October 27, 2021 08:52

Inactive


          upd creds

6d72df0

annalvova05 temporarily deployed to more-secrets

October 27, 2021 10:51

Inactive


          upd auth for different creds

908e15a

Contributor Author

annalvova05 commented Oct 27, 2021 •

edited by github-actions bot

Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1389956499
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1389956499
🐛

annalvova05 temporarily deployed to more-secrets

October 27, 2021 11:49

Inactive

jrhizor temporarily deployed to more-secrets

October 27, 2021 11:50

Inactive


          rename creds

f874716

Contributor Author

annalvova05 commented Oct 27, 2021 •

edited by github-actions bot

Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1390066099
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1390066099
🐛

annalvova05 temporarily deployed to more-secrets

October 27, 2021 12:19

Inactive

jrhizor temporarily deployed to more-secrets

October 27, 2021 12:21

Inactive


          rename creds

876b721

annalvova05 temporarily deployed to more-secrets

October 27, 2021 12:40

Inactive

Contributor Author

annalvova05 commented Oct 27, 2021 •

edited by github-actions bot

Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1390145050
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1390145050
🐛 https://gradle.com/s/j5bqeo3thcyne

jrhizor temporarily deployed to more-secrets

October 27, 2021 12:42

Inactive

annalvova05 requested a review from midavadim

January 12, 2022 13:41

annalvova05 marked this pull request as ready for review

January 12, 2022 13:41

midavadim reviewed

View reviewed changes

airbyte-integrations/connectors/source-mailchimp/integration_tests/invalid_config.json Outdated Show resolved Hide resolved


          add invalid_config

8511bc0

annalvova05 temporarily deployed to more-secrets

January 13, 2022 10:25

Inactive

octavia-squidington-iii temporarily deployed to more-secrets

January 13, 2022 10:26

Inactive

annalvova05 requested a review from midavadim

January 13, 2022 10:36

octavia-squidington-iii temporarily deployed to more-secrets

January 13, 2022 13:14

Inactive


          Merge remote-tracking branch 'origin/master' into alvova/6273-add-oau…

105db17

…th-implementation

Contributor Author

annalvova05 commented Jan 13, 2022 •

edited by github-actions bot

Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1693054001
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1693054001
🐛 https://gradle.com/s/okk63u7co6gqa
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 25 passed, 1 skipped in 1175.95s (0:19:35) =============

annalvova05 temporarily deployed to more-secrets

January 13, 2022 14:01

Inactive

octavia-squidington-iii temporarily deployed to more-secrets

January 13, 2022 14:02

Inactive

Contributor Author

annalvova05 commented Jan 14, 2022 •

edited by github-actions bot

Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1696907949
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1696907949
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                   Stmts   Miss  Cover
	 ----------------------------------------------------------
	 source_mailchimp/__init__.py               2      0   100%
	 source_mailchimp/models/__init__.py        1      1     0%
	 source_mailchimp/models/mailchimp.py       7      7     0%
	 source_mailchimp/source.py                45     14    69%
	 source_mailchimp/streams.py              103     61    41%
	 ----------------------------------------------------------
	 TOTAL                                    158     83    47%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 26 passed, 1 skipped in 1084.15s (0:18:04) ==================

octavia-squidington-iii temporarily deployed to more-secrets

January 14, 2022 09:02

Inactive

midavadim approved these changes

View reviewed changes

Contributor

antixar commented Jan 14, 2022

@annalvova05 , Please publish your changes

Contributor Author

annalvova05 commented Jan 14, 2022 •

edited by github-actions bot

Loading

/publish connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1697289188
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1697289188

octavia-squidington-iii temporarily deployed to more-secrets

January 14, 2022 10:45

Inactive

Contributor Author

annalvova05 commented Jan 14, 2022 •

edited by github-actions bot

Loading

/publish connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1697404722
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1697404722

octavia-squidington-iii temporarily deployed to more-secrets

January 14, 2022 11:15

Inactive

Contributor Author

annalvova05 commented Jan 17, 2022 •

edited by github-actions bot

Loading

/publish connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1707170609
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1707170609

octavia-squidington-iii temporarily deployed to more-secrets

January 17, 2022 09:21

Inactive

annalvova05 added 2 commits

January 17, 2022 12:00


          bump version

95ea02a


          Merge remote-tracking branch 'origin/master' into alvova/6273-add-oau…

4fa7eb6

…th-implementation

annalvova05 temporarily deployed to more-secrets

January 17, 2022 10:02

Inactive


          format

16bb4b3

annalvova05 merged commit d09829b into master

annalvova05 deleted the alvova/6273-add-oauth-implementation branch

January 17, 2022 10:21

annalvova05 temporarily deployed to more-secrets

January 17, 2022 10:21

Inactive

octavia-squidington-iii mentioned this pull request

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9630

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment