Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source MongoDB v2: Fixed nested document parsing #7160

Merged
merged 10 commits into from
Oct 25, 2021
Merged

Source MongoDB v2: Fixed nested document parsing #7160

merged 10 commits into from
Oct 25, 2021

Conversation

irynakruk
Copy link
Contributor

@irynakruk irynakruk commented Oct 19, 2021 •
edited
Loading

What

Connector is not extracting the raw data from the database

How

Parse Document as string instead of JSON.

Recommended reading order

  1. MongoUtils.java

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@irynakruk irynakruk linked an issue Oct 19, 2021 that may be closed by this pull request
MongoDB (v2 - Java) connector is not extracting the raw data from the database #6498
Closed
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 19, 2021
@irynakruk irynakruk temporarily deployed to more-secrets October 19, 2021 12:09 Inactive
@irynakruk irynakruk temporarily deployed to more-secrets October 21, 2021 12:10 Inactive
@irynakruk
Copy link
Contributor Author

irynakruk commented Oct 21, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1368773337
❌ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1368773337
🐛

@jrhizor jrhizor temporarily deployed to more-secrets October 21, 2021 16:27 Inactive
@irynakruk irynakruk temporarily deployed to more-secrets October 21, 2021 16:33 Inactive
@irynakruk irynakruk temporarily deployed to more-secrets October 21, 2021 20:39 Inactive
@irynakruk
Copy link
Contributor Author

irynakruk commented Oct 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1372101191
❌ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1372101191
🐛

@irynakruk irynakruk marked this pull request as ready for review October 22, 2021 12:09
@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 12:13 Inactive
@irynakruk irynakruk requested review from sherifnada and removed request for davinchia October 22, 2021 13:28
@irynakruk irynakruk temporarily deployed to more-secrets October 22, 2021 14:12 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 14:16 Inactive
@irynakruk
Copy link
Contributor Author

irynakruk commented Oct 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1372591607
❌ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1372591607
🐛 https://gradle.com/s/xqs5vi6f6hsbi

@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 14:32 Inactive
@irynakruk
Copy link
Contributor Author

irynakruk commented Oct 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1372647806
❌ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1372647806
🐛 https://gradle.com/s/muusbhzytmctm

@irynakruk irynakruk temporarily deployed to more-secrets October 22, 2021 14:46 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 14:47 Inactive
@irynakruk irynakruk temporarily deployed to more-secrets October 22, 2021 15:48 Inactive
@irynakruk
Copy link
Contributor Author

irynakruk commented Oct 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1372871203
❌ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1372871203
🐛 https://gradle.com/s/wbe6zwkitbhnw

@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 15:51 Inactive
@irynakruk
Copy link
Contributor Author

irynakruk commented Oct 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1373012236
❌ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1373012236
🐛 https://gradle.com/s/ftjunndl25sqi

@irynakruk irynakruk temporarily deployed to more-secrets October 22, 2021 16:31 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 16:33 Inactive
@irynakruk irynakruk temporarily deployed to more-secrets October 22, 2021 17:11 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 17:12 Inactive
@irynakruk
Fixed test v4
3f8b9b4
@irynakruk
Merge remote-tracking branch 'origin/irynakruk/6498-source-mongo-fix-…
a3d51dc 
…doc' into irynakruk/6498-source-mongo-fix-doc

# Conflicts:
#	airbyte-integrations/connectors/source-mongodb-v2/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/MongoDbSourceDataTypeTest.java
@irynakruk
Copy link
Contributor Author

irynakruk commented Oct 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1373300875
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1373300875
No Python unittests run

@irynakruk irynakruk temporarily deployed to more-secrets October 22, 2021 18:05 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 22, 2021 18:06 Inactive
sherifnada
sherifnada approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼

@irynakruk
Copy link
Contributor Author

irynakruk commented Oct 25, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1380980225
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1380980225

@jrhizor jrhizor temporarily deployed to more-secrets October 25, 2021 12:12 Inactive
@irynakruk irynakruk temporarily deployed to more-secrets October 25, 2021 12:25 Inactive
@irynakruk irynakruk merged commit dbfd6ca into master Oct 25, 2021
@irynakruk irynakruk deleted the irynakruk/6498-source-mongo-fix-doc branch October 25, 2021 13:16
@jrhizor jrhizor mentioned this pull request Nov 1, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@irynakruk @schlattk
Source MongoDB v2: Fixed nested document parsing (airbytehq#7160)
a2f9135 
* Fixed nested document parsing: added parsing of nested documents and arrays, added data types test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@etsybaev etsybaev Awaiting requested review from etsybaev

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MongoDB (v2 - Java) connector is not extracting the raw data from the database
4 participants
@irynakruk @sherifnada @alexandr-shegeda @jrhizor