Update Mockito for running tests on Mac M1 #7208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jrhizor
reviewed
Oct 20, 2021
jrhizor
reviewed
Oct 20, 2021
tuliren
approved these changes
Oct 20, 2021
jrhizor
approved these changes
Oct 20, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* Update Mockito for running tests on Mac M1 * Added comments for JNA library dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what the change is solving
Fix running tests on Mac M1 and further fixes #2017
How
Update Mockito verison
Recommended reading order
build.gradle
Pre-merge Checklist
TODO's
There are a couple of failing tests though
https://github.com/airbytehq/airbyte/blob/master/airbyte-commons/src/test/java/io/airbyte/commons/util/AutoCloseableIteratorsTest.java#L39
https://github.com/airbytehq/airbyte/blob/master/airbyte-workers/src/test/java/io/airbyte/workers/process/DockerProcessFactoryTest.java#L26 (Needs docker platform handling)