Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish PR 6930: google dir fix members #7218

Merged
merged 4 commits into from Oct 21, 2021

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 20, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 20, 2021

/test connector=connectors/source-google-directory

🕑 connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1364125904
✅ connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1364125904
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                  Stmts   Miss  Cover
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-directory/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 ---------------------------------------------------------
	   self._warn("No data was collected.", slug="no-data-collected")
	 main_dev.py                               6      6     0%
	 source_google_directory/__init__.py       2      2     0%
	 source_google_directory/api.py           74     74     0%
	 source_google_directory/client.py        24     24     0%
	 source_google_directory/source.py         4      4     0%
	 source_google_directory/utils.py          3      3     0%
	 ---------------------------------------------------------
	 TOTAL                                   113    113     0%

@marcosmarxm marcosmarxm temporarily deployed to more-secrets October 20, 2021 15:05 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 20, 2021 15:08 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 20, 2021

/publish connector=connectors/source-google-directory

🕑 connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1364160636
❌ connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1364160636

@jrhizor jrhizor temporarily deployed to more-secrets October 20, 2021 15:16 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 20, 2021

/publish connector=connectors/source-google-directory

🕑 connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1364387275
❌ connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1364387275

@jrhizor jrhizor temporarily deployed to more-secrets October 20, 2021 16:15 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 20, 2021 16:16 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 20, 2021

/publish connector=connectors/source-google-directory

🕑 connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1364584861
❌ connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1364584861

@jrhizor jrhizor temporarily deployed to more-secrets October 20, 2021 17:14 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 20, 2021

/publish connector=connectors/source-google-directory

🕑 connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1365153358
❌ connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1365153358

@marcosmarxm marcosmarxm temporarily deployed to more-secrets October 20, 2021 20:06 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 20, 2021 20:07 Inactive
@marcosmarxm
Copy link
Member Author

lol, now tests are failing from nowhere.

@jrhizor jrhizor temporarily deployed to more-secrets October 21, 2021 18:04 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 21, 2021

/publish connector=connectors/source-google-directory

🕑 connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1369135835
✅ connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1369135835

@jrhizor jrhizor temporarily deployed to more-secrets October 21, 2021 18:18 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets October 21, 2021 18:34 Inactive
@marcosmarxm marcosmarxm merged commit 0585a5d into master Oct 21, 2021
@marcosmarxm marcosmarxm deleted the marcos/publish-cmm-6930-google-dir branch October 21, 2021 20:32
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Google Directory: Fix crash if there's a group don't have members

* bump version

Co-authored-by: Xiangxuan Liu <xiangxuan.liu@rightcapital.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants