Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Helm chart: Using helper to get postgres credentials #7235

Merged

Conversation

gergelylendvai
Copy link
Contributor

What

For several helm chart components the db secret was collected in various ways and some components were not able to connect to the db because it was not consistent.

How

DB secret is fetched in all affected components from the configmap if the postgres helm chart is used otherwise from a secret which is identified by the named template.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2021

CLA assistant check
All committers have signed the CLA.

@gergelylendvai gergelylendvai changed the title 馃悰Helm chart: Using helper to get postgres credentials 馃悰 Helm chart: Using helper to get postgres credentials Oct 21, 2021
@jrhizor jrhizor self-requested a review October 21, 2021 16:15
@marcosmarxm marcosmarxm self-assigned this Oct 22, 2021
@jrhizor
Copy link
Contributor

jrhizor commented Oct 27, 2021

Thanks @gergelylendvai !

@jrhizor jrhizor merged commit aa2caf1 into airbytehq:master Oct 27, 2021
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants