add optional spec field to source and destination definitions #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmossman
commented
Oct 21, 2021
| @@ -85,7 +85,8 @@ public void setup() throws IOException, JsonValidationException, ConfigNotFoundE | |||
| .withDockerRepository("test") | |||
| .withDocumentationUrl("http://doc") | |||
| .withIcon("hello") | |||
| .withDockerImageTag("dev"); | |||
| .withDockerImageTag("dev") | |||
| .withSpec(new ConnectorSpecification()); | |||
There was a problem hiding this comment.
Wasn't sure which unit test was best to update for this change; I chose this one since it was already instantiating other optional fields in the source and destination definitions.
cgardens
approved these changes
Oct 22, 2021
| @@ -85,7 +85,8 @@ public void setup() throws IOException, JsonValidationException, ConfigNotFoundE | |||
| .withDockerRepository("test") | |||
| .withDocumentationUrl("http://doc") | |||
| .withIcon("hello") | |||
| .withDockerImageTag("dev"); | |||
| .withDockerImageTag("dev") | |||
| .withSpec(new ConnectorSpecification()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses issue #7134.
Adds an optional spec field to the StandardSourceDefinition and StandardDestinationDefinition classes in order to allow specs to be stored directly in the database, which in turn will allow us to remove the need to call
specon a connector every time we need the spec, after further changes are made in later PRs.How
Adds the optional
specfield to the source and destination definition JSON schemas, and instantiates this new field in a unit test.Recommended reading order
airbyte-config/models/src/main/resources/types/StandardDestinationDefinition.yamlairbyte-config/models/src/main/resources/types/StandardSourceDefinition.yamlairbyte-server/src/test/java/io/airbyte/server/ConfigDumpImporterTest.javaPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes