Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fullstory only for cloud #7298

Merged
merged 5 commits into from
Oct 26, 2021
Merged

Enable fullstory only for cloud #7298

merged 5 commits into from
Oct 26, 2021

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented Oct 23, 2021

What

Closes #6922.
Closes #6587

Also moved config-specific stuff into proper place and disabled fileConfigProvider as part of #6923

@jamakase jamakase requested a review from jrhizor October 23, 2021 12:40
@jamakase jamakase added area/frontend type/enhancement New feature or request labels Oct 23, 2021
@jamakase jamakase self-assigned this Oct 23, 2021
@jamakase jamakase temporarily deployed to more-secrets October 23, 2021 12:42 Inactive
@jamakase
Copy link
Contributor Author

Also added @cgardens to reviewers so you guys could see how config was actually supposed to be used and won't apply hacks in the future.

@jamakase jamakase temporarily deployed to more-secrets October 23, 2021 13:01 Inactive
@jamakase jamakase temporarily deployed to more-secrets October 23, 2021 21:16 Inactive
@jamakase jamakase temporarily deployed to more-secrets October 23, 2021 21:20 Inactive
@jamakase jamakase merged commit ac754ce into master Oct 26, 2021
@jamakase jamakase deleted the jamakase/enable-fullstory branch October 26, 2021 18:10
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
2 participants