add cli commons to factor out common parsing code #7301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
approved these changes
Oct 25, 2021
| @@ -0,0 +1,7 @@ | |||
| plugins { | |||
There was a problem hiding this comment.
is it overkill to add a README for this module describing it's purpose?
There was a problem hiding this comment.
lol. i guess if you have to ask it's not overkill :D I'll add it.
| void testGetTaggedImageName() { | ||
| final String repository = "airbyte/repo"; | ||
| final String tag = "12.3"; | ||
| assertEquals("airbyte/repo:12.3", Clis.getTaggedImageName(repository, tag)); |
There was a problem hiding this comment.
where is this method defined? am I being thick? it's not in Clis.java
| import org.apache.commons.cli.Options; | ||
| import org.apache.commons.cli.ParseException; | ||
|
|
||
| public class Clis { |
There was a problem hiding this comment.
we should probably have at least one test for each public method in this class
benmoriceau
approved these changes
Oct 25, 2021
| } | ||
| default -> throw new IllegalStateException("Unexpected value: " + command); | ||
| } | ||
|
|
||
| final CommandLine parsed = runParse(options, args, command); | ||
| final CommandLine parsed = Clis.parse(args, options, command.toString().toLowerCase()); |
There was a problem hiding this comment.
Why the command enum is not used here and we use string instead?
There was a problem hiding this comment.
it's the trade off of DRYing this is that the common parse function can't really reasonably know about the enum, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What