-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4280/connectors guides #7312
4280/connectors guides #7312
Conversation
isalikov
commented
Oct 24, 2021
•
edited
edited
- Documentation can be shown when user create source/destination if docs markdown are available
For fetching documents markdown as text Also I was use http-server localy for serve content from |
@avaidyanatha heads up! it's happening! |
...-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx
Outdated
Show resolved
Hide resolved
...-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/pages/SourcesPage/pages/CreateSourcePage/components/SourceForm.tsx
Outdated
Show resolved
Hide resolved
COPY build /usr/share/nginx/html | ||
RUN rm -rf /usr/share/nginx/html/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgardens do you remember by any chance why was this line added? It looks like it removes docs from serving from nginx. Is it what we really want? I believe we still want to access this files from UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great when configuring the source and destination directly.
There are two issues:
- It's easy to get stuck. Would it be easy to make clicking outside of the doc pane (for example if someone clicked to go to settings) to close out the docs pane?
- Accessing the guide during onboarding breaks the styling:
It's also very easy to feel stuck in this situation because you have to horizontally scroll to see thex
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Applied qfix so we can merge it |
* feat: s/d docs popup * feat: useDocumentation hook * feat: SetupGuide as single component Co-authored-by: Artem Astapenko <jamakase54@gmail.com>