Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Python Connector template: Remove Deprecated Dependency for Python Sources #7385

Merged

Conversation

yevhenii-ldv
Copy link
Contributor

@yevhenii-ldv yevhenii-ldv commented Oct 26, 2021

What

part of #7242.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@yevhenii-ldv yevhenii-ldv self-assigned this Oct 26, 2021
@yevhenii-ldv yevhenii-ldv added this to the Connectors 2021-10-29 milestone Oct 26, 2021
@avida
Copy link
Contributor

avida commented Oct 26, 2021

Please update source-scaffold-source-python as well

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 26, 2021 14:03 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 27, 2021

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1392090360
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1392090360
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 main_dev.py                   6      6     0%
	 source_file/__init__.py       2      0   100%
	 source_file/client.py       238     37    84%
	 source_file/source.py        49     35    29%
	 ---------------------------------------------
	 TOTAL                       295     78    74%

@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 21:45 Inactive
@sherifnada
Copy link
Contributor

@yevhenii-ldv make sure to expand & follow the checklist for the generator

…urochkin/remove-deprecated-dependency-gradle-file

� Conflicts:
�	airbyte-integrations/connector-templates/source-python/build.gradle.hbs
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 15, 2021 14:20 Inactive
@yevhenii-ldv yevhenii-ldv changed the title Python Connector template: Remove Deprecated Dependency for Python HTTP API Python Connector template: Remove Deprecated Dependency for Python Sources Nov 16, 2021
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 16, 2021 14:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 16, 2021 14:11 Inactive
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 16, 2021 14:23 Inactive
@yevhenii-ldv yevhenii-ldv changed the title Python Connector template: Remove Deprecated Dependency for Python Sources 🎉 Python Connector template: Remove Deprecated Dependency for Python Sources Nov 17, 2021
@yevhenii-ldv yevhenii-ldv merged commit a391194 into master Nov 17, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/remove-deprecated-dependency-gradle-file branch November 17, 2021 09:39
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…Sources (airbytehq#7385)

* Remove Deprecated Dependency for Python API Template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants