Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source File: Migrate File source to CDK structure #7387

Merged
merged 9 commits into from
Oct 29, 2021
Merged

🎉 Source File: Migrate File source to CDK structure #7387

merged 9 commits into from
Oct 29, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

What

resolves #7336.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 26, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1385963159

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 26, 2021
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 26, 2021 13:59 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 26, 2021 14:01 Inactive
@yevhenii-ldv yevhenii-ldv changed the title 🎉 Source File: Migrate Looker source to CDK structure 🎉 Source File: Migrate File source to CDK structure Oct 26, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 26, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1386075959

@jrhizor jrhizor temporarily deployed to more-secrets October 26, 2021 14:27 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 26, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1386131368

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 26, 2021 14:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 26, 2021 14:39 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1392035318
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1392035318
🐛 https://gradle.com/s/5t4jjrykmukeo

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 27, 2021 21:25 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 21:26 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1392410588
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1392410588
🐛 https://gradle.com/s/66q7prrnqbma6

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 27, 2021 23:46 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 23:47 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1395036073
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1395036073
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 source_file/__init__.py       2      0   100%
	 source_file/client.py       238     37    84%
	 source_file/source.py        50     35    30%
	 ---------------------------------------------
	 TOTAL                       290     72    75%

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 28, 2021 14:25 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 14:26 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1395926959
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1395926959
🐛 https://gradle.com/s/mxzi7nw4ahyry

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 28, 2021 18:29 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 18:31 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1395983362
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1395983362
🐛 https://gradle.com/s/j6z35r3hzt5ig

@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 18:48 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1396024567
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1396024567
🐛 https://gradle.com/s/mds7sru5wgvps

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 28, 2021 18:58 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 19:01 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1396147588
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1396147588
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 source_file/__init__.py       2      0   100%
	 source_file/client.py       237     37    84%
	 source_file/source.py        50     35    30%
	 ---------------------------------------------
	 TOTAL                       289     72    75%

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 28, 2021 19:36 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 19:36 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1396177268
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1396177268
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 source_file/__init__.py       2      0   100%
	 source_file/client.py       237     37    84%
	 source_file/source.py        50     35    30%
	 ---------------------------------------------
	 TOTAL                       289     72    75%

@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 19:46 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 28, 2021
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 28, 2021 20:01 Inactive
@htrueman
Copy link
Contributor

htrueman commented Oct 29, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1398475899
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1398475899

@jrhizor jrhizor temporarily deployed to more-secrets October 29, 2021 10:07 Inactive
@htrueman htrueman merged commit 269298c into master Oct 29, 2021
@htrueman htrueman deleted the ykurochkin/source-file-refactor-to-use-cdk branch October 29, 2021 10:15
@jrhizor jrhizor mentioned this pull request Nov 1, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@yevhenii-ldv @schlattk
🎉 Source File: Migrate File source to CDK structure (airbytehq#7387)
9d66402 
* Migrate File source to CDK structure

* fix .dockerignore file

* remove SAT requirements

* update Dockerfile

* change Dockerfile to base images python:3.7-slim

* add SAT tests

* update tests

* add secret/config.json for source-file

* update changelogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htrueman htrueman htrueman approved these changes

@avida avida Awaiting requested review from avida

@Zirochkaa Zirochkaa Awaiting requested review from Zirochkaa

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source File: Refactor to use the CDK
4 participants
@yevhenii-ldv @htrueman @jrhizor @octavia-squidington-iii