Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base-python gradle dependencies in connectors where base-python is not used #7499

Merged
merged 29 commits into from
Nov 10, 2021

Conversation

htrueman
Copy link
Contributor

@htrueman htrueman commented Oct 29, 2021

What

Part of #7242 story.

How

Updated connectors with base-python, but where base-python is not used.

  • Removed base-python references.
  • Removed requirements.txt.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 29, 2021
@htrueman htrueman self-assigned this Oct 29, 2021
@htrueman htrueman changed the title Htrueman/remove base python gradle dependencies Remove base-python gradle dependencies in connectors where base-python is not used Oct 29, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 1, 2021
@htrueman htrueman temporarily deployed to more-secrets November 1, 2021 20:15 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 2, 2021 07:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 2, 2021 07:44 Inactive
@htrueman htrueman temporarily deployed to more-secrets November 9, 2021 20:05 Inactive
@htrueman
Copy link
Contributor Author

htrueman commented Nov 9, 2021

/publish connector=connectors/source-shortio

🕑 connectors/source-shortio https://github.com/airbytehq/airbyte/actions/runs/1441321219
✅ connectors/source-shortio https://github.com/airbytehq/airbyte/actions/runs/1441321219

@htrueman htrueman temporarily deployed to more-secrets November 9, 2021 20:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 20:45 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 20:53 Inactive
@htrueman
Copy link
Contributor Author

htrueman commented Nov 9, 2021

/publish connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697

@htrueman
Copy link
Contributor Author

htrueman commented Nov 9, 2021

/publish connector=connectors/source-us-census

🕑 connectors/source-us-census https://github.com/airbytehq/airbyte/actions/runs/1441500484
✅ connectors/source-us-census https://github.com/airbytehq/airbyte/actions/runs/1441500484

@htrueman
Copy link
Contributor Author

htrueman commented Nov 9, 2021

/publish connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/1441501021
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/1441501021

@htrueman htrueman temporarily deployed to more-secrets November 9, 2021 21:36 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 21:37 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 21:37 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 21:37 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 21:48 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 21:59 Inactive
…e-python-gradle-dependencies

# Conflicts:
#	airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/12928b32-bf0a-4f1e-964f-07e12e37153a.json
#	airbyte-config/init/src/main/resources/seed/source_definitions.yaml
#	airbyte-integrations/connectors/source-intercom/Dockerfile
#	airbyte-integrations/connectors/source-mixpanel/Dockerfile
#	docs/integrations/sources/intercom.md
#	docs/integrations/sources/mixpanel.md
@htrueman htrueman temporarily deployed to more-secrets November 10, 2021 10:57 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 10:58 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 10:58 Inactive
@htrueman htrueman merged commit 504580d into master Nov 10, 2021
@htrueman htrueman deleted the htrueman/remove-base-python-gradle-dependencies branch November 10, 2021 11:12
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…n is not used (airbytehq#7499)

* Remeve base-python references.

* Add requirements.txt

* Fix requirements.txt blank line

* Fix source-exchange rates to common CDK approach

* Fix source-smartsheets SAT.
Fix source-exchange-rates build.gradle.

* Bump docker version

* Update source-dixa SAT config

* Fix source-exchange-rates SAT config

* Revert bump scaffold sources version

* Fix source-shortio SAT config

* Fix source-square invalid_config.json

* Fix source-us-census invalid_config.json

* Fix source-intercom versioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants