🎉 CI secrets: migration to GSM #7528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zendesk_support/streams.py Co-authored-by: George Claireaux <george@claireaux.co.uk>
|
/test connector=connectors/source-s3
|
|
/test connector=connectors/source-s3
|
|
/test connector=connectors/source-s3
|
|
/test connector=connectors/source-s3
|
sherifnada
reviewed
Nov 9, 2021
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
|
|
/test connector=connectors/source-zendesk-support
|
…rbyte into antixar/3732-gsm-ci-secrets
|
/test connector=connectors/source-zendesk-support
|
|
/test connector=connectors/source-s3
|
|
/test connector=connectors/source-zendesk-support
|
|
/test connector=connectors/source-commercetools
|
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* fix 404 responses for the ticket_comments stream * add unit test * add unit test * add oauth2 access token * Update airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py Co-authored-by: George Claireaux <george@claireaux.co.uk> * switching among auth methods * update spec file * update CI secrets logic * update CI secrets logic * remove debug data * add a debug message * fix json convertation * fix json convertation * support one secret by several connectors * Update tools/bin/ci_credentials.sh Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * Update tools/bin/ci_credentials.sh Co-authored-by: LiRen Tu <tuliren@gmail.com> * update function names * update docs * reset failed changes * update json set value * update secrets json key * Update tools/bin/ci_credentials.sh * add JSON validation * Update docs/connector-development/README.md Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * update doc * Update README.md * rename the function write_standard_creds Co-authored-by: Maksym Pavlenok <maksym.pavlenok@globallogic.com> Co-authored-by: George Claireaux <george@claireaux.co.uk> Co-authored-by: Sherif A. Nada <snadalive@gmail.com> Co-authored-by: LiRen Tu <tuliren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Details here
How
This decision provides backward compatibility with all secrets workflows. All old settings should work after this changes.
How to add permissions for working with Google Secret Manager(GSM):
Each developer should have the role
Development_CI_Secretsof the projectdataline-integration-testingNow these permissions are provided for GL Python/Java teams only.
How to add new secrets:
SECRET_./secrets/config.jsontestcommand for your connector/For examples:
Labels:
Result: value =>
airbyte-integrations/connectors/source-s3/secrets/config.jsonLabels:
Result: value =>
airbyte-integrations/connectors/source-zendesk-support/secrets/config_auth.jsonLabels:
Result:
airbyte-integrations/connectors/source-google-analytics/secrets/config.jsonairbyte-integrations/connectors/source-google-drive/secrets/config.jsonHow to migrate to the new secrets' logic:
tools/bin/ci_credentials.shRecommended reading order
.github/workflows/{publish|test}-command.yml- removed all secrets' values because the new script version will select necessary ones only.tools/lib/gcp-token.sh- functions for generation of Google tokens. It can be used not only for the current task.tools/bin/ci_credentials.sh- changes of all CI secrets' logicPre-merge Checklist
Connector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes