remove migration docker build #7542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliren
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
How much time does it save? I think the safest approach is to only remove the build after we remove the file-based migration completely. Before that is done, it is still possible (though unlikely) that we want to tweak this module to keep it compatible with the latest config changes.
|
moving to draft until we remove file-based migrations |
cgardens
approved these changes
Nov 3, 2021
|
already done separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually use the migration docker image anymore so we don't really have a reason to continue building it.