Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iterable memory consumption #7591

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Fix iterable memory consumption #7591

merged 1 commit into from
Nov 3, 2021

Conversation

avida
Copy link
Contributor

@avida avida commented Nov 3, 2021

Resolves #7558

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 3, 2021
@avida
Copy link
Contributor Author

avida commented Nov 3, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1416610818
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1416610818
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       33     22    33%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  891    435    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_iterable/__init__.py       2      0   100%
	 source_iterable/api.py          218     82    62%
	 source_iterable/source.py        15      7    53%
	 -------------------------------------------------
	 TOTAL                           235     89    62%

@avida avida temporarily deployed to more-secrets November 3, 2021 12:04 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 3, 2021 12:06 Inactive
@avida
Copy link
Contributor Author

avida commented Nov 3, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1416739547
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1416739547

@jrhizor jrhizor temporarily deployed to more-secrets November 3, 2021 12:40 Inactive
@avida avida merged commit 0c2fcb8 into master Nov 3, 2021
@avida avida deleted the drezchykov/iterable-fix branch November 3, 2021 12:50
@jrhizor jrhizor mentioned this pull request Nov 3, 2021
Merged
lmossman pushed a commit that referenced this pull request Nov 3, 2021
@lmossman
Fix iterable memory consumption (#7591)
e22e319
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@schlattk
Fix iterable memory consumption (airbytehq#7591)
9d4c698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevhenii-ldv yevhenii-ldv yevhenii-ldv approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iterable Sync timeout/cancelation due to Memory Error/Heartbeat Failure
3 participants
@avida @yevhenii-ldv @jrhizor