Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Recharge: improve 'backoff' for HTTP requests #7626

Merged
merged 6 commits into from
Nov 8, 2021

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Nov 4, 2021

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

This Airbyte connector can fail time to time because of incorrect HTTP responses from API server.
For example you can catch such HTTP response

Content-Length = 337948
len(response.content) => 11922

As you can see 'Content-Length' of response much bigger then real response body length.
I propose to re-request such broken responses, extending current backoff mechanism.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 4, 2021
@grubberr grubberr temporarily deployed to more-secrets November 4, 2021 10:56 Inactive
@grubberr grubberr self-assigned this Nov 4, 2021
@grubberr grubberr changed the title improve 'backoff' for requests 🎉 Source Recharge: improve 'backoff' for HTTP requests Nov 4, 2021
@grubberr
Copy link
Contributor Author

grubberr commented Nov 4, 2021

/test connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1421019201
✅ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1421019201
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	   self._warn("No data was collected.", slug="no-data-collected")
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_recharge/__init__.py       2      2     0%
	 source_recharge/api.py           75     75     0%
	 source_recharge/source.py        21     21     0%
	 -------------------------------------------------
	 TOTAL                            98     98     0%

@jrhizor jrhizor temporarily deployed to more-secrets November 4, 2021 11:29 Inactive
@grubberr grubberr requested review from yevhenii-ldv, annalvova05 and antixar and removed request for yevhenii-ldv November 4, 2021 12:35
@grubberr grubberr linked an issue Nov 4, 2021 that may be closed by this pull request
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 4, 2021 16:02 Inactive
@grubberr grubberr temporarily deployed to more-secrets November 4, 2021 18:42 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 5, 2021
@grubberr grubberr temporarily deployed to more-secrets November 5, 2021 15:06 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@antixar
Copy link
Contributor

antixar commented Nov 5, 2021

@grubberr
Please publish and merge this PR. This solution is obvious and should help to fix the bug

@grubberr
Copy link
Contributor Author

grubberr commented Nov 5, 2021

/publish connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1426405532
✅ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1426405532

@jrhizor jrhizor temporarily deployed to more-secrets November 5, 2021 15:54 Inactive
@grubberr grubberr merged commit af903f2 into master Nov 8, 2021
@grubberr grubberr deleted the grubberr/7469-source-recharge branch November 8, 2021 08:23
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* backoff for successful but incomplete responses

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Recharge: API return mal-formated JSON need to implement retry
5 participants