Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source IBM Db2: Connector provides wrong values for a datatype #7670

Merged
merged 10 commits into from
Nov 11, 2021
Merged

🐛 Source IBM Db2: Connector provides wrong values for a datatype #7670

merged 10 commits into from
Nov 11, 2021

Conversation

andriikorotkov
Copy link
Contributor

@andriikorotkov andriikorotkov commented Nov 5, 2021 •
edited
Loading

What

General source implementation:

DECFLOAT : in case of NaN, +Infinity, -Infinity fails with com.ibm.db2.jcc.am.SqlException during conversion to BigDecimal.

2021-11-05_16-57

2021-11-05_16-55

2021-11-05_16-56

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@andriikorotkov andriikorotkov linked an issue Nov 5, 2021 that may be closed by this pull request
Source IBM Db2: Connector provides wrong values for a datatype #4291
Closed
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 5, 2021
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 5, 2021 13:25 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 5, 2021 13:54 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 8, 2021 14:17 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 8, 2021 14:33 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 8, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1435357223
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1435357223
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets November 8, 2021 15:07 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 9, 2021 09:56 Inactive
alexandr-shegeda
alexandr-shegeda approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publish and merge without airbyte review

@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
f363c46 
…4291-db2-datatypes-cast

� Conflicts:
�	docs/integrations/sources/db2.md
@alexandr-shegeda alexandr-shegeda marked this pull request as ready for review November 11, 2021 16:25
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 11, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1449639092
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1449639092
No Python unittests run

@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 11, 2021 16:27 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 11, 2021 16:29 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 11, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1449826186
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1449826186

@jrhizor jrhizor temporarily deployed to more-secrets November 11, 2021 17:22 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 11, 2021 18:10 Inactive
@andriikorotkov andriikorotkov merged commit 6d30ba4 into master Nov 11, 2021
@andriikorotkov andriikorotkov deleted the akorotkov/4291-db2-datatypes-cast branch November 11, 2021 18:39
This was referenced Nov 11, 2021
Closed
Closed
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@andriikorotkov @schlattk
🐛 Source IBM Db2: Connector provides wrong values for a datatype (air…
c6cadaa 
…bytehq#7670)

* added DB2 type transformation

* added DB2 type transformation

* fixed code style

* fixed remarks

* fixed remarks

* fixed remarks

* added java doc for certificate generation

* bump new version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etsybaev etsybaev etsybaev approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@DoNotPanicUA DoNotPanicUA Awaiting requested review from DoNotPanicUA

@tuliren tuliren Awaiting requested review from tuliren

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/db2 connectors/sources-database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source IBM Db2: Connector provides wrong values for a datatype
5 participants
@andriikorotkov @etsybaev @alexandr-shegeda @jrhizor @karinakuz