Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split sync worlflow #7690

Merged
merged 3 commits into from
Nov 8, 2021
Merged

split sync worlflow #7690

merged 3 commits into from
Nov 8, 2021

Conversation

benmoriceau
Copy link
Contributor

What

Split the sync workflow into multiple files

@benmoriceau benmoriceau added type/enhancement New feature or request area/platform issues related to the platform labels Nov 5, 2021
@github-actions github-actions bot added the area/worker Related to worker label Nov 5, 2021
@benmoriceau benmoriceau temporarily deployed to more-secrets November 5, 2021 23:16 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 5, 2021 23:41 Inactive
davinchia
davinchia approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you redo this? I thought I saw another similar PR to this.

@benmoriceau benmoriceau merged commit 291dccb into master Nov 8, 2021
@benmoriceau benmoriceau deleted the bmoric/split-sync-workflow branch November 8, 2021 19:09
@benmoriceau
Copy link
Contributor Author

Did you redo this? I thought I saw another similar PR to this.

Yes, I had to resplit the files. The conflict resolution is complicated for this review. I prefer to restart it from scratch.

@jrhizor jrhizor mentioned this pull request Nov 8, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@benmoriceau @schlattk
split sync worlflow (airbytehq#7690)
8b60900 
Split the sync workflow into multiple files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens cgardens approved these changes

@davinchia davinchia davinchia approved these changes

@jrhizor jrhizor Awaiting requested review from jrhizor

@lmossman lmossman Awaiting requested review from lmossman

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benmoriceau @cgardens @davinchia