Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to node 16 #7724

Merged
merged 2 commits into from
Nov 8, 2021
Merged

upgrade to node 16 #7724

merged 2 commits into from
Nov 8, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Nov 8, 2021

It'd be nice to be on the latest active LTS.

It seems like upgrading Node 16 causes a failure during npm install where we get a 401 for Font Awesome. @jamakase any ideas why this is happening?
EDIT: it looks like this is working after upgrading fontawesome. I don't know why.

Also, is the new lock file version ok for us to switch to like this?

@jrhizor jrhizor requested a review from jamakase November 8, 2021 07:08
@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform labels Nov 8, 2021
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my fresh Airbyte install I did upgraded to Node 16 and successfully build the application from your branch, it was previously failing due to 401 error that required npm login. It looks like FontAwesome requires auth for previous versions...

@jrhizor jrhizor temporarily deployed to more-secrets November 8, 2021 19:58 Inactive
@jrhizor
Copy link
Contributor Author

jrhizor commented Nov 8, 2021

Artem confirmed this is fine on Slack.

@jrhizor jrhizor merged commit ce3426c into master Nov 8, 2021
@jrhizor jrhizor deleted the jrhizor/upgrade-node branch November 8, 2021 20:55
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* upgrade to node 16

* does upgrading fontawesome prevent errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants