Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve discover catalog ref fields #7734

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Resolve discover catalog ref fields #7734

merged 1 commit into from
Nov 9, 2021

Conversation

avida
Copy link
Contributor

@avida avida commented Nov 8, 2021

Resolves #7725

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit labels Nov 8, 2021
@avida avida force-pushed the drezchykov/facebook-ref-resolve branch from e497a4f to 32cd4af Compare November 8, 2021 12:14
@avida avida temporarily deployed to more-secrets November 8, 2021 12:16 Inactive
@avida
Copy link
Contributor Author

avida commented Nov 9, 2021 •
edited by github-actions bot
Loading

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/1438865765
✅ https://github.com/airbytehq/airbyte/actions/runs/1438865765

@avida
Copy link
Contributor Author

avida commented Nov 9, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1439007280
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1439007280

@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 10:28 Inactive
@avida avida merged commit 16b626c into master Nov 9, 2021
@avida avida deleted the drezchykov/facebook-ref-resolve branch November 9, 2021 10:42
@jrhizor jrhizor mentioned this pull request Nov 9, 2021
Merged
@sherifnada sherifnada mentioned this pull request Nov 15, 2021
Closed
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@schlattk
Resolve discover catalog ref fields (airbytehq#7734)
795b59d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htrueman htrueman htrueman approved these changes

@Zirochkaa Zirochkaa Zirochkaa approved these changes

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/facebook-marketing connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Facebook Marketing does not resolve refs correctly
5 participants
@avida @htrueman @Zirochkaa @jrhizor @karinakuz