🐛 Destination BigQuery-Denormalized: Fix JSON with $ref Definition keys #7736

alexandertsukanov · 2021-11-08T13:50:54Z

What

The issue appears when Airbyte trying to parse JSON fields that contain $ref definition. e.g.

{ 
  "type" : [ "null", "object" ],
  "properties" : {
    "users": {
      "$ref": "#/definitions/users_"
    }
  }
}

The main problem such values come to BigQueryDenormalizedRecordConsumer.java as ObjecNode classes, despite the fact Schema type of this column is StandardSQLTypeName.STRING.

How

The handling for such a case was added to BigQueryDenormalizedDestination.java and BigQueryDenormalizedRecordConsumer.java . Now, such fields will be stored as raw String JSON at BigQuery DB.
e.g.
See integration tests.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

alexandertsukanov · 2021-11-08T14:59:04Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1435327112
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1435327112
No Python unittests run

alexandertsukanov · 2021-11-08T15:55:56Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1435568412
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1435568412
🐛

…alized_datetime_fix

alexandertsukanov · 2021-11-08T16:52:10Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1435787395
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1435787395
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

alexandr-shegeda

LGTM. we can proceed with publish and merge without airbyte review

alexandertsukanov · 2021-11-09T11:03:09Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1439143216
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1439143216

…alized_datetime_fix

…ys (airbytehq#7736) * BUG-6638: Fix fields with $ref definition. * BUG-6638: Added integration tests. * BUG-6638: Added integration tests. * BUG-6638: Added integration tests. * BUG-6638: Added doc and pumped Dockerfile version. * BUG-6638: Added doc and pumped Dockerfile version. * BUG-6638: replaced for with forEach * BUG-6638: Bumped specification

alexandertsukanov added 2 commits November 8, 2021 14:18

BUG-6638: Fix fields with $ref definition.

cfd1263

BUG-6638: Added integration tests.

966c6a9

alexandertsukanov requested review from etsybaev and alexandr-shegeda November 8, 2021 13:50

github-actions bot added the area/connectors Connector related issues label Nov 8, 2021

BUG-6638: Added integration tests.

ef575ac

alexandertsukanov temporarily deployed to more-secrets November 8, 2021 14:05 Inactive

alexandertsukanov linked an issue Nov 8, 2021 that may be closed by this pull request

Destination BigQuery Desnormalized: JSON table encountered too many errors, giving up. Rows: 1; errors: 1. Please look into the errors[] collection for more details #6638

Closed

jrhizor temporarily deployed to more-secrets November 8, 2021 14:20 Inactive

BUG-6638: Added integration tests.

5bd826c

alexandertsukanov temporarily deployed to more-secrets November 8, 2021 14:58 Inactive

jrhizor temporarily deployed to more-secrets November 8, 2021 15:01 Inactive

jrhizor temporarily deployed to more-secrets November 8, 2021 15:18 Inactive

jrhizor temporarily deployed to more-secrets November 8, 2021 15:58 Inactive

Merge branch 'master' into otsukanov/6638_destination_bigquery_denorm…

b0dc514

…alized_datetime_fix

alexandertsukanov temporarily deployed to more-secrets November 8, 2021 16:53 Inactive

jrhizor temporarily deployed to more-secrets November 8, 2021 16:54 Inactive

BUG-6638: Added doc and pumped Dockerfile version.

8429cb3

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 8, 2021

BUG-6638: Added doc and pumped Dockerfile version.

d46f5eb

alexandertsukanov temporarily deployed to more-secrets November 8, 2021 17:01 Inactive

BUG-6638: replaced for with forEach

50ae3ed

alexandertsukanov temporarily deployed to more-secrets November 9, 2021 08:20 Inactive

alexandr-shegeda approved these changes Nov 9, 2021

View reviewed changes

alexandr-shegeda marked this pull request as ready for review November 9, 2021 10:18

jrhizor temporarily deployed to more-secrets November 9, 2021 11:05 Inactive

alexandertsukanov added 2 commits November 9, 2021 13:26

Merge branch 'master' into otsukanov/6638_destination_bigquery_denorm…

c4f3cfb

…alized_datetime_fix

BUG-6638: Bumped specification

5ee6558

alexandertsukanov temporarily deployed to more-secrets November 9, 2021 11:35 Inactive

alexandertsukanov merged commit 48d8250 into master Nov 9, 2021

alexandertsukanov deleted the otsukanov/6638_destination_bigquery_denormalized_datetime_fix branch November 9, 2021 11:39

jrhizor mentioned this pull request Nov 9, 2021

Bump Airbyte version from 0.30.36-alpha to 0.30.37-alpha #7800

Merged

sherifnada mentioned this pull request Nov 10, 2021

🐛 Destination BQ Denormalized: handle null values in fields described by a $ref schema #7804

Merged

16 tasks

karinakuz added connectors/destination/bigquery-denormalized connectors/destinations-api connectors/destination/bigquery connectors/destinations-warehouse and removed connectors/destinations-api labels Jan 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Destination BigQuery-Denormalized: Fix JSON with $ref Definition keys #7736

🐛 Destination BigQuery-Denormalized: Fix JSON with $ref Definition keys #7736

alexandertsukanov commented Nov 8, 2021 •

edited

alexandertsukanov commented Nov 8, 2021 •

edited by github-actions bot

alexandertsukanov commented Nov 8, 2021 •

edited by github-actions bot

alexandertsukanov commented Nov 8, 2021 •

edited by github-actions bot

alexandr-shegeda left a comment

alexandertsukanov commented Nov 9, 2021 •

edited by github-actions bot

🐛 Destination BigQuery-Denormalized: Fix JSON with $ref Definition keys #7736

🐛 Destination BigQuery-Denormalized: Fix JSON with $ref Definition keys #7736

Conversation

alexandertsukanov commented Nov 8, 2021 • edited

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

alexandertsukanov commented Nov 8, 2021 • edited by github-actions bot

alexandertsukanov commented Nov 8, 2021 • edited by github-actions bot

alexandertsukanov commented Nov 8, 2021 • edited by github-actions bot

alexandr-shegeda left a comment

Choose a reason for hiding this comment

alexandertsukanov commented Nov 9, 2021 • edited by github-actions bot

alexandertsukanov commented Nov 8, 2021 •

edited

alexandertsukanov commented Nov 8, 2021 •

edited by github-actions bot

alexandertsukanov commented Nov 8, 2021 •

edited by github-actions bot

alexandertsukanov commented Nov 8, 2021 •

edited by github-actions bot

alexandertsukanov commented Nov 9, 2021 •

edited by github-actions bot