Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Bmoric/remove docker compose for build (#7500)" (#7698)" #7746

Merged
merged 8 commits into from
Nov 8, 2021
Merged

Revert "Revert "Bmoric/remove docker compose for build (#7500)" (#7698)" #7746

merged 8 commits into from
Nov 8, 2021

Conversation

benmoriceau
Copy link
Contributor

This reverts commit 797d11a.

What

Restore the removal of the docker compose file

@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/scheduler area/server area/worker Related to worker labels Nov 8, 2021
@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 17:43 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 19:04 Inactive
@benmoriceau benmoriceau marked this pull request as ready for review November 8, 2021 19:09
@jrhizor
Copy link
Contributor

jrhizor commented Nov 8, 2021

Can you replace the other docs occurrences of composeBuild?

❯ rg --hidden composeBuild
airbyte-tests/src/automaticMigrationAcceptanceTest/java/io/airbyte/test/automaticMigrationAcceptance/MigrationAcceptanceTest.java
50: * composeBuild and replace System.getenv("MIGRATION_TEST_VERSION") with the version in your .env

docs/contributing-to-airbyte/developing-on-kubernetes.md
14:./gradlew composeBuild # build dev images

docs/contributing-to-airbyte/gradle-cheatsheet.md
76:SUB_BUILD=PLATFORM ./gradlew composeBuild

@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 20:01 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 20:58 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 21:10 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 21:27 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 21:33 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 21:43 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2021 21:47 Inactive
@benmoriceau benmoriceau merged commit 42b378f into master Nov 8, 2021
@benmoriceau benmoriceau deleted the bmoric/restore-remove-docker-compose branch November 8, 2021 22:16
@jrhizor jrhizor mentioned this pull request Nov 8, 2021
Merged
@benmoriceau benmoriceau mentioned this pull request Nov 9, 2021
Closed
@jamakase jamakase mentioned this pull request Nov 11, 2021
Closed
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@benmoriceau @schlattk
Revert "Revert "Bmoric/remove docker compose for build (airbytehq#7500)…
9ddda23 
…" (airbytehq#7698)" (airbytehq#7746)

This reverts commit 797d11a.

Restore the removal of the docker compose file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

@cgardens cgardens Awaiting requested review from cgardens

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation area/platform issues related to the platform area/scheduler area/server area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benmoriceau @jrhizor