Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Cart: add stream addresses #7767

Merged
merged 6 commits into from Nov 10, 2021
Merged

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 8, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 8, 2021 23:56 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cart change LGTM but can you remove the amazon change?

@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 9, 2021 03:17 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 9, 2021

/test connector=connectors/source-cart

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1440619176
❌ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1440619176
🐛 https://gradle.com/s/ovpow5qln257g

@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 17:27 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 9, 2021

/test connector=connectors/source-cart

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1440678082
❌ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1440678082
🐛 https://gradle.com/s/4ogtwqdd6swwq

@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 9, 2021 17:42 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 17:43 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 9, 2021 18:00 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 10, 2021

/test connector=connectors/source-cart

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1445350929
✅ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1445350929
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-cart/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 ---------------------------------------------
	 source_cart/__init__.py       2      2     0%
	   self._warn("No data was collected.", slug="no-data-collected")
	 source_cart/source.py        52     52     0%
	 source_cart/streams.py       71     71     0%
	 ---------------------------------------------
	 TOTAL                       125    125     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 source_cart/__init__.py       2      2     0%
	 source_cart/source.py        52     52     0%
	 source_cart/streams.py       71     71     0%
	 ---------------------------------------------
	 TOTAL                       125    125     0%

@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 17:25 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 10, 2021

/publish connector=connectors/source-cart

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1445453453
✅ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1445453453

@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 17:53 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 10, 2021 20:10 Inactive
@marcosmarxm marcosmarxm merged commit dac49d1 into master Nov 10, 2021
@marcosmarxm marcosmarxm deleted the marcos/cart-add-stream-addresses branch November 10, 2021 20:28
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* change check_connection for Amazon Seller Partner

* add new stream addresses

* correct configured_catalog

* correct abnormal_state

* run airbyte config seed file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants