Fix BufferedStreamConsumer tests #7773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliren
approved these changes
Nov 9, 2021
| - "format" | ||
| - "azure_blob_storage_account_name" | ||
| - "azure_blob_storage_account_key" | ||
| - "format" |
There was a problem hiding this comment.
Are these formatting changes expected?
There was a problem hiding this comment.
this was the output of the format
|
|
||
| @Test | ||
| public void testIt() { | ||
| for (int i = 1; i < 1000; i++) { |
There was a problem hiding this comment.
Iterating 1000 times does not seem necessary since the current implementation is a naive one.
ChristopheDuong
approved these changes
Nov 9, 2021
sherifnada
commented
Nov 9, 2021
airbyte-commons/src/main/java/io/airbyte/commons/bytes/ByteUtils.java
Outdated
Show resolved
Hide resolved
| - "format" | ||
| - "azure_blob_storage_account_name" | ||
| - "azure_blob_storage_account_key" | ||
| - "format" |
There was a problem hiding this comment.
this was the output of the format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#7719 introduced changes to bufferedStreamconsumer but I goofed and forgot to fix unit tests. This PR fixes the unit tests by making them byte-based instead of record-count-based.