Do not ignore tools/bin #7801
Do not ignore tools/bin #7801
Conversation
benmoriceau
added
type/bug
.gitignore
Outdated
| /bin/ | ||
| /**/bin/ |
There was a problem hiding this comment.
Why are /bin/ and /**/bin/ ignored in the first place?
There was a problem hiding this comment.
Why are
/bin/and/**/bin/ignored in the first place?
Good question, I have no idea. I choose the option with the lower risk based on what I saw here, but ideally we should remove the exclusion.
There was a problem hiding this comment.
If you build #7005 (which added this change) does it create binaries that should be ignored? If so, can you move the ignore to that level instead of global.
There was a problem hiding this comment.
The build passed without any file changes so it should be ok to remove the ignore. I didn't manage to run the buildlocally though
There was a problem hiding this comment.
Did you build this connector specifically? If so then we're good to go.
There was a problem hiding this comment.
yes, it is not generating anything in any bin folder.
…-t-ignore-tools-bin
Avoid ignoring a file that shouldn't be ignored.
What
Avoid ignoring a file that shouldn't be ignored.