add OAuth 2.0 for microsoft_teams source connector #7807

grubberr · 2021-11-10T06:45:45Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

How

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2021-12-12T16:14:59Z

/test connector=connectors/source-microsoft-teams

🕑 connectors/source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/1569879289
✅ connectors/source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/1569879289
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	   self._warn("No data was collected.", slug="no-data-collected")
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_microsoft_teams/__init__.py       2      2     0%
	 source_microsoft_teams/client.py       176    176     0%
	 source_microsoft_teams/source.py        33     33     0%
	 --------------------------------------------------------
	 TOTAL                                  211    211     0%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 15 passed, 1 skipped in 125.19s (0:02:05) ===================

ChristopheDuong

Sorry, this might be the first connector with input config values from the connector, so the signatures of the base methods might also need to be adapted adequately.

ChristopheDuong · 2021-12-13T13:53:44Z

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/MicrosoftTeamsOAuthFlow.java

+  @Override
+  protected String getAccessTokenUrl() {


Suggested change

@Override

protected String getAccessTokenUrl() {

@Override

protected String getAccessTokenUrl(final JsonNode inputOAuthConfiguration) {

This method should be modified in airbyte-oauth/src/main/java/io/airbyte/oauth/BaseOAuth2Flow.java to also include the config object to the call.

All Oauth flow implementation that are not depending on a value from connector config should ignore that extra argument

All Oauth flow implementation that are depending on a value from connector config can access the necessary value from that input config argument

ChristopheDuong · 2021-12-13T13:56:47Z

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/MicrosoftTeamsOAuthFlow.java

+  private static final String fieldName = "tenant_id";
+  private static String tenantId;


These should not be present as static variables in the class.

Please adapt the signature of the parent base methods accordingly to pass the input configuration from the connector around in the parent classes.

You might need to change the signature of BaseOAuth2Flow.completeOAuthFlow to also include the inputConfiguration.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/MicrosoftTeamsOAuthFlow.java

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/MicrosoftTeamsOAuthFlow.java

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2021-12-13T16:29:28Z

/test connector=connectors/source-microsoft-teams

🕑 connectors/source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/1573860703
✅ connectors/source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/1573860703
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-microsoft-teams/.venv/lib/python3.8/site-packages/coverage/control.py:768: CoverageWarning: No data was collected. (no-data-collected)
	 source_microsoft_teams/__init__.py       2      2     0%
	 source_microsoft_teams/client.py       176    176     0%
	 source_microsoft_teams/source.py        33     33     0%
	 --------------------------------------------------------
	   self._warn("No data was collected.", slug="no-data-collected")
	 TOTAL                                  211    211     0%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 15 passed, 1 skipped in 109.33s (0:01:49) ===================

grubberr · 2021-12-13T16:41:48Z

/publish connector=connectors/source-microsoft-teams

🕑 connectors/source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/1573912358
✅ connectors/source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/1573912358

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

* add OAuth 2.0 for microsoft_teams source connector Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

add OAuth 2.0 for microsoft_teams source connector

d65eddc

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/connectors Connector related issues label Nov 10, 2021

grubberr linked an issue Nov 10, 2021 that may be closed by this pull request

Source Microsoft Teams: support oauth #7704

Closed

grubberr temporarily deployed to more-secrets November 10, 2021 06:46 Inactive

grubberr self-assigned this Nov 10, 2021

grubberr added 2 commits November 10, 2021 09:07

Merge branch 'master' into grubberr/7704-source-microsoft-teams

8c87b42

bump version 0.2.2 -> 0.2.3

7f28921

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 10, 2021

grubberr temporarily deployed to more-secrets November 10, 2021 07:53 Inactive

authSpecification added

b5f9825

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets November 10, 2021 09:33 Inactive

grubberr added 2 commits November 10, 2021 12:46

Merge branch 'master' into grubberr/7704-source-microsoft-teams

dade790

MicrosoftTeamsOAuthFlow.java added

76a64e6

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets November 10, 2021 11:56 Inactive

grubberr added 2 commits November 10, 2021 18:29

Merge branch 'master' into grubberr/7704-source-microsoft-teams

d8403ff

getScopes added

6ed96f5

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets November 10, 2021 18:45 Inactive

grubberr added 2 commits November 13, 2021 10:52

Merge branch 'master' into grubberr/7704-source-microsoft-teams

942260a

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/7704-source-microsoft-teams

8e61a41

grubberr temporarily deployed to more-secrets November 13, 2021 17:09 Inactive

grubberr added 2 commits November 18, 2021 12:26

Merge branch 'master' into grubberr/7704-source-microsoft-teams

55b8b84

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fix formatConsentUrl

6d37423

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets November 18, 2021 10:51 Inactive

grubberr added 2 commits November 25, 2021 17:58

Merge branch 'master' into grubberr/7704-source-microsoft-teams

13b320b

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

lint code

8f68634

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets November 25, 2021 16:13 Inactive

grubberr added 2 commits December 7, 2021 22:32

Merge branch 'master' into grubberr/7704-source-microsoft-teams

42bd078

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bump version 0.2.3 -> 0.2.4

02fec68

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets December 7, 2021 20:42 Inactive

Merge branch 'master' into grubberr/7704-source-microsoft-teams

f8c7ab7

MicrosoftTeamsOAuthFlowTest.java added

efb1851

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets December 12, 2021 16:06 Inactive

jrhizor temporarily deployed to more-secrets December 12, 2021 16:17 Inactive

grubberr requested review from ChristopheDuong and Phlair December 12, 2021 16:41

ChristopheDuong suggested changes Dec 13, 2021

View reviewed changes

grubberr added 2 commits December 13, 2021 17:16

Merge branch 'master' into grubberr/7704-source-microsoft-teams

046decb

pass inputOAuthConfiguration to getAccessTokenUrl method

fde20a8

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets December 13, 2021 16:00 Inactive

ChristopheDuong reviewed Dec 13, 2021

View reviewed changes

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/MicrosoftTeamsOAuthFlow.java Outdated Show resolved Hide resolved

ChristopheDuong reviewed Dec 13, 2021

View reviewed changes

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/MicrosoftTeamsOAuthFlow.java Outdated Show resolved Hide resolved

lint code

c09d965

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

ChristopheDuong reviewed Dec 13, 2021

View reviewed changes

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/MicrosoftTeamsOAuthFlow.java Outdated Show resolved Hide resolved

ChristopheDuong approved these changes Dec 13, 2021

View reviewed changes

grubberr temporarily deployed to more-secrets December 13, 2021 16:15 Inactive

improve 'not supported' message

0394383

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets December 13, 2021 16:23 Inactive

jrhizor temporarily deployed to more-secrets December 13, 2021 16:31 Inactive

jrhizor temporarily deployed to more-secrets December 13, 2021 16:43 Inactive

grubberr added 2 commits December 13, 2021 18:55

Merge branch 'master' into grubberr/7704-source-microsoft-teams

5475a43

source_specs.yaml updated

430e442

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr merged commit 346b411 into master Dec 13, 2021

grubberr deleted the grubberr/7704-source-microsoft-teams branch December 13, 2021 16:59

grubberr temporarily deployed to more-secrets December 13, 2021 17:01 Inactive

jrhizor mentioned this pull request Dec 14, 2021

Bump Airbyte version from 0.33.11-alpha to 0.33.12-alpha #8787

Merged

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022

add OAuth 2.0 for microsoft_teams source connector (airbytehq#7807)

b7525c5

* add OAuth 2.0 for microsoft_teams source connector Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add OAuth 2.0 for microsoft_teams source connector #7807

add OAuth 2.0 for microsoft_teams source connector #7807

grubberr commented Nov 10, 2021 •

edited

Loading

grubberr commented Dec 12, 2021 •

edited by github-actions bot

Loading

ChristopheDuong left a comment •

edited

Loading

ChristopheDuong Dec 13, 2021 •

edited

Loading

ChristopheDuong Dec 13, 2021 •

edited

Loading

grubberr commented Dec 13, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 13, 2021 •

edited by github-actions bot

Loading

		private static final String fieldName = "tenant_id";
		private static String tenantId;

add OAuth 2.0 for microsoft_teams source connector #7807

add OAuth 2.0 for microsoft_teams source connector #7807

Conversation

grubberr commented Nov 10, 2021 • edited Loading

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

grubberr commented Dec 12, 2021 • edited by github-actions bot Loading

ChristopheDuong left a comment • edited Loading

Choose a reason for hiding this comment

ChristopheDuong Dec 13, 2021 • edited Loading

Choose a reason for hiding this comment

ChristopheDuong Dec 13, 2021 • edited Loading

Choose a reason for hiding this comment

grubberr commented Dec 13, 2021 • edited by github-actions bot Loading

grubberr commented Dec 13, 2021 • edited by github-actions bot Loading

grubberr commented Nov 10, 2021 •

edited

Loading

grubberr commented Dec 12, 2021 •

edited by github-actions bot

Loading

ChristopheDuong left a comment •

edited

Loading

ChristopheDuong Dec 13, 2021 •

edited

Loading

ChristopheDuong Dec 13, 2021 •

edited

Loading

grubberr commented Dec 13, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 13, 2021 •

edited by github-actions bot

Loading