Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Facebook: add the "videos" stream. #7855

Merged
merged 5 commits into from
Nov 19, 2021

Conversation

zestyping
Copy link
Contributor

@zestyping zestyping commented Nov 11, 2021

What

This PR adds the missing "videos" stream to the Facebook Marketing source.

How

The new Videos class is very similar to the existing Ads and Campaigns classes; it is just a simple subclass of FBMarketingIncrementalStream. The schema, defined in videos.json, is based on the Facebook API documentation at https://developers.facebook.com/docs/marketing-api/reference/video and includes all the fields that Facebook would allow.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 11, 2021
@zestyping zestyping changed the title Source Facebook: add the "videos" stream. 🎉 Source Facebook: add the "videos" stream. Nov 11, 2021
@marcosmarxm
Copy link
Member

@zestyping can you solve the conflicts?

@zestyping
Copy link
Contributor Author

Okay, I've rebased on master and resolved the merge conflicts.

@github-actions github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/scheduler area/server area/worker Related to worker kubernetes normalization labels Nov 19, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 19, 2021 22:20 Inactive
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zestyping

@marcosmarxm marcosmarxm merged commit aac54da into airbytehq:master Nov 19, 2021
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Source Facebook: add the "videos" stream.

* bump the version

* run seed and update doc

Co-authored-by: Marcos Marx <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants